From: patchwork-bot+netdevbpf@kernel.org
To: Yuan Chen <chenyuan_fl@163.com>
Cc: andrii@kernel.org, olsajiri@gmail.com, bpf@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v2 1/1] selftests/bpf: Fix procmap_query()'s params mismatch and compilation warning
Date: Wed, 04 Sep 2024 19:00:33 +0000 [thread overview]
Message-ID: <172547643301.1133672.14786879825802356513.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20240903012839.3178-1-chenyuan_fl@163.com>
Hello:
This patch was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@kernel.org>:
On Tue, 3 Sep 2024 09:28:39 +0800 you wrote:
> From: Yuan Chen <chenyuan@kylinos.cn>
>
> When the PROCMAP_QUERY is not defined, a compilation error occurs due to the
> mismatch of the procmap_query()'s params, procmap_query() only be called in
> the file where the function is defined, modify the params so they can match.
>
> We get a warning when build samples/bpf:
> trace_helpers.c:252:5: warning: no previous prototype for ‘procmap_query’ [-Wmissing-prototypes]
> 252 | int procmap_query(int fd, const void *addr, __u32 query_flags, size_t *start, size_t *offset, int *flags)
> | ^~~~~~~~~~~~~
> As this function is only used in the file, mark it as 'static'.
>
> [...]
Here is the summary with links:
- [v2,1/1] selftests/bpf: Fix procmap_query()'s params mismatch and compilation warning
https://git.kernel.org/bpf/bpf-next/c/02baa0a2a677
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2024-09-04 19:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 1:28 [PATCH v2 1/1] selftests/bpf: Fix procmap_query()'s params mismatch and compilation warning Yuan Chen
2024-09-04 19:00 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172547643301.1133672.14786879825802356513.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=chenyuan_fl@163.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=olsajiri@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox