From: patchwork-bot+netdevbpf@kernel.org
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, netdev@vger.kernel.org,
larysa.zaremba@intel.com, wojciech.drewek@intel.com,
michal.kubiak@intel.com, jacob.e.keller@intel.com,
amritha.nambiar@intel.com, przemyslaw.kitszel@intel.com,
sridhar.samudrala@intel.com, maciej.fijalkowski@intel.com,
magnus.karlsson@intel.com, ast@kernel.org, daniel@iogearbox.net,
hawk@kernel.org, john.fastabend@gmail.com, bpf@vger.kernel.org
Subject: Re: [PATCH net 0/6][pull request] ice: fix synchronization between .ndo_bpf() and reset
Date: Thu, 05 Sep 2024 02:10:31 +0000 [thread overview]
Message-ID: <172550223126.1227714.3911146774586738228.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20240903183034.3530411-1-anthony.l.nguyen@intel.com>
Hello:
This series was applied to netdev/net.git (main)
by Tony Nguyen <anthony.l.nguyen@intel.com>:
On Tue, 3 Sep 2024 11:30:26 -0700 you wrote:
> Larysa Zaremba says:
>
> PF reset can be triggered asynchronously, by tx_timeout or by a user. With some
> unfortunate timings both ice_vsi_rebuild() and .ndo_bpf will try to access and
> modify XDP rings at the same time, causing system crash.
>
> The first patch factors out rtnl-locked code from VSI rebuild code to avoid
> deadlock. The following changes lock rebuild and .ndo_bpf() critical sections
> with an internal mutex as well and provide complementary fixes.
>
> [...]
Here is the summary with links:
- [net,1/6] ice: move netif_queue_set_napi to rtnl-protected sections
https://git.kernel.org/netdev/net/c/2a5dc090b92c
- [net,2/6] ice: protect XDP configuration with a mutex
https://git.kernel.org/netdev/net/c/2504b8405768
- [net,3/6] ice: check for XDP rings instead of bpf program when unconfiguring
https://git.kernel.org/netdev/net/c/f50c68763436
- [net,4/6] ice: check ICE_VSI_DOWN under rtnl_lock when preparing for reset
https://git.kernel.org/netdev/net/c/d8c40b9d3a6c
- [net,5/6] ice: remove ICE_CFG_BUSY locking from AF_XDP code
https://git.kernel.org/netdev/net/c/7e3b407ccbea
- [net,6/6] ice: do not bring the VSI up, if it was down before the XDP setup
https://git.kernel.org/netdev/net/c/04c7e14e5b0b
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2024-09-05 2:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 18:30 [PATCH net 0/6][pull request] ice: fix synchronization between .ndo_bpf() and reset Tony Nguyen
2024-09-03 18:30 ` [PATCH net 1/6] ice: move netif_queue_set_napi to rtnl-protected sections Tony Nguyen
2024-09-03 18:30 ` [PATCH net 2/6] ice: protect XDP configuration with a mutex Tony Nguyen
2024-09-03 18:30 ` [PATCH net 3/6] ice: check for XDP rings instead of bpf program when unconfiguring Tony Nguyen
2024-09-03 18:30 ` [PATCH net 4/6] ice: check ICE_VSI_DOWN under rtnl_lock when preparing for reset Tony Nguyen
2024-09-03 18:30 ` [PATCH net 5/6] ice: remove ICE_CFG_BUSY locking from AF_XDP code Tony Nguyen
2024-09-03 18:30 ` [PATCH net 6/6] ice: do not bring the VSI up, if it was down before the XDP setup Tony Nguyen
2024-09-05 2:10 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172550223126.1227714.3911146774586738228.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=amritha.nambiar@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=larysa.zaremba@intel.com \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=michal.kubiak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=sridhar.samudrala@intel.com \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox