BPF List
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel.org
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: bpf@vger.kernel.org, shung-hsi.yu@suse.com, andrii@kernel.org,
	ast@kernel.org, kongln9170@gmail.com
Subject: Re: [PATCH bpf-next v5 1/9] bpf: Fix bpf_strtol and bpf_strtoul helpers for 32bit
Date: Fri, 13 Sep 2024 20:31:25 +0000	[thread overview]
Message-ID: <172625948552.2358571.7329976357946121826.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20240913191754.13290-1-daniel@iogearbox.net>

Hello:

This series was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@kernel.org>:

On Fri, 13 Sep 2024 21:17:46 +0200 you wrote:
> The bpf_strtol() and bpf_strtoul() helpers are currently broken on 32bit:
> 
> The argument type ARG_PTR_TO_LONG is BPF-side "long", not kernel-side "long"
> and therefore always considered fixed 64bit no matter if 64 or 32bit underlying
> architecture.
> 
> This contract breaks in case of the two mentioned helpers since their BPF_CALL
> definition for the helpers was added with {unsigned,}long *res. Meaning, the
> transition from BPF-side "long" (BPF program) to kernel-side "long" (BPF helper)
> breaks here.
> 
> [...]

Here is the summary with links:
  - [bpf-next,v5,1/9] bpf: Fix bpf_strtol and bpf_strtoul helpers for 32bit
    https://git.kernel.org/bpf/bpf-next/c/cfe69c50b055
  - [bpf-next,v5,2/9] bpf: Remove truncation test in bpf_strtol and bpf_strtoul helpers
    https://git.kernel.org/bpf/bpf-next/c/7d71f59e0280
  - [bpf-next,v5,3/9] bpf: Fix helper writes to read-only maps
    https://git.kernel.org/bpf/bpf-next/c/32556ce93bc4
  - [bpf-next,v5,4/9] bpf: Improve check_raw_mode_ok test for MEM_UNINIT-tagged types
    https://git.kernel.org/bpf/bpf-next/c/18752d73c189
  - [bpf-next,v5,5/9] bpf: Zero former ARG_PTR_TO_{LONG,INT} args in case of error
    https://git.kernel.org/bpf/bpf-next/c/4b3786a6c539
  - [bpf-next,v5,6/9] selftests/bpf: Fix ARG_PTR_TO_LONG {half-,}uninitialized test
    https://git.kernel.org/bpf/bpf-next/c/b8e188f023e0
  - [bpf-next,v5,7/9] selftests/bpf: Rename ARG_PTR_TO_LONG test description
    https://git.kernel.org/bpf/bpf-next/c/b073b82d4d3c
  - [bpf-next,v5,8/9] selftests/bpf: Add a test case to write strtol result into .rodata
    https://git.kernel.org/bpf/bpf-next/c/2e3f06602047
  - [bpf-next,v5,9/9] selftests/bpf: Add a test case to write mtu result into .rodata
    https://git.kernel.org/bpf/bpf-next/c/211bf9cf178a

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



      parent reply	other threads:[~2024-09-13 20:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-13 19:17 [PATCH bpf-next v5 1/9] bpf: Fix bpf_strtol and bpf_strtoul helpers for 32bit Daniel Borkmann
2024-09-13 19:17 ` [PATCH bpf-next v5 2/9] bpf: Remove truncation test in bpf_strtol and bpf_strtoul helpers Daniel Borkmann
2024-09-13 19:17 ` [PATCH bpf-next v5 3/9] bpf: Fix helper writes to read-only maps Daniel Borkmann
2024-09-13 19:17 ` [PATCH bpf-next v5 4/9] bpf: Improve check_raw_mode_ok test for MEM_UNINIT-tagged types Daniel Borkmann
2024-09-13 19:17 ` [PATCH bpf-next v5 5/9] bpf: Zero former ARG_PTR_TO_{LONG,INT} args in case of error Daniel Borkmann
2024-09-13 19:17 ` [PATCH bpf-next v5 6/9] selftests/bpf: Fix ARG_PTR_TO_LONG {half-,}uninitialized test Daniel Borkmann
2024-09-13 19:17 ` [PATCH bpf-next v5 7/9] selftests/bpf: Rename ARG_PTR_TO_LONG test description Daniel Borkmann
2024-09-13 19:17 ` [PATCH bpf-next v5 8/9] selftests/bpf: Add a test case to write strtol result into .rodata Daniel Borkmann
2024-09-13 19:17 ` [PATCH bpf-next v5 9/9] selftests/bpf: Add a test case to write mtu " Daniel Borkmann
2024-09-13 20:31 ` patchwork-bot+netdevbpf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=172625948552.2358571.7329976357946121826.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel.org \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=kongln9170@gmail.com \
    --cc=shung-hsi.yu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox