From: patchwork-bot+netdevbpf@kernel.org
To: =?utf-8?b?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2VuIDx0b2tlQHJlZGhhdC5jb20+?=@aws-us-west-2-korg-oddjob-rhel9-1.codeaurora.org
Cc: ast@kernel.org, daniel@iogearbox.net, john.fastabend@gmail.com,
andrii@kernel.org, martin.lau@linux.dev, eddyz87@gmail.com,
song@kernel.org, yonghong.song@linux.dev, kpsingh@kernel.org,
sdf@fomichev.me, haoluo@google.com, jolsa@kernel.org,
memxor@gmail.com, simon.sundberg@kau.se, bpf@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH bpf v2 0/3] Fix caching of BTF for kfuncs in the verifier
Date: Thu, 10 Oct 2024 18:00:29 +0000 [thread overview]
Message-ID: <172858322977.2114175.5921702022516465256.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20241010-fix-kfunc-btf-caching-for-modules-v2-0-745af6c1af98@redhat.com>
Hello:
This series was applied to bpf/bpf.git (master)
by Alexei Starovoitov <ast@kernel.org>:
On Thu, 10 Oct 2024 15:27:06 +0200 you wrote:
> When playing around with defining kfuncs in some custom modules, we
> noticed that if a BPF program calls two functions with the same
> signature in two different modules, the function from the wrong module
> may sometimes end up being called. Whether this happens depends on the
> order of the calls in the BPF program, which turns out to be due to the
> use of sort() inside __find_kfunc_desc_btf() in the verifier code.
>
> [...]
Here is the summary with links:
- [bpf,v2,1/3] bpf: fix kfunc btf caching for modules
https://git.kernel.org/bpf/bpf/c/6cb86a0fdece
- [bpf,v2,2/3] selftests/bpf: Provide a generic [un]load_module helper
https://git.kernel.org/bpf/bpf/c/4192bb294f80
- [bpf,v2,3/3] selftests/bpf: Add test for kfunc module order
https://git.kernel.org/bpf/bpf/c/f91b256644ea
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2024-10-10 18:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 13:27 [PATCH bpf v2 0/3] Fix caching of BTF for kfuncs in the verifier Toke Høiland-Jørgensen
2024-10-10 13:27 ` [PATCH bpf v2 1/3] bpf: fix kfunc btf caching for modules Toke Høiland-Jørgensen
2024-10-10 13:27 ` [PATCH bpf v2 2/3] selftests/bpf: Provide a generic [un]load_module helper Toke Høiland-Jørgensen
2024-10-10 13:27 ` [PATCH bpf v2 3/3] selftests/bpf: Add test for kfunc module order Toke Høiland-Jørgensen
2024-10-10 18:00 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172858322977.2114175.5921702022516465256.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc==?utf-8?b?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2VuIDx0b2tlQHJlZGhhdC5jb20+?=@aws-us-west-2-korg-oddjob-rhel9-1.codeaurora.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sdf@fomichev.me \
--cc=simon.sundberg@kau.se \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox