From: patchwork-bot+netdevbpf@kernel.org
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: bpf@vger.kernel.org, nathaniel.theis@nccgroup.com,
ast@kernel.org, eddyz87@gmail.com, andrii@kernel.org,
john.fastabend@gmail.com
Subject: Re: [PATCH bpf 1/3] bpf: Fix incorrect delta propagation between linked registers
Date: Thu, 17 Oct 2024 18:10:30 +0000 [thread overview]
Message-ID: <172918863097.2561819.16960201256166830425.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20241016134913.32249-1-daniel@iogearbox.net>
Hello:
This series was applied to bpf/bpf.git (master)
by Andrii Nakryiko <andrii@kernel.org>:
On Wed, 16 Oct 2024 15:49:11 +0200 you wrote:
> Nathaniel reported a bug in the linked scalar delta tracking, which can lead
> to accepting a program with OOB access. The specific code is related to the
> sync_linked_regs() function and the BPF_ADD_CONST flag, which signifies a
> constant offset between two scalar registers tracked by the same register id.
>
> The verifier attempts to track "similar" scalars in order to propagate bounds
> information learned about one scalar to others. For instance, if r1 and r2
> are known to contain the same value, then upon encountering 'if (r1 != 0x1234)
> goto xyz', not only does it know that r1 is equal to 0x1234 on the path where
> that conditional jump is not taken, it also knows that r2 is.
>
> [...]
Here is the summary with links:
- [bpf,1/3] bpf: Fix incorrect delta propagation between linked registers
https://git.kernel.org/bpf/bpf/c/3878ae04e9fc
- [bpf,2/3] bpf: Fix print_reg_state's constant scalar dump
https://git.kernel.org/bpf/bpf/c/3e9e708757ca
- [bpf,3/3] selftests/bpf: Add test case for delta propagation
https://git.kernel.org/bpf/bpf/c/db123e42304d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2024-10-17 18:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 13:49 [PATCH bpf 1/3] bpf: Fix incorrect delta propagation between linked registers Daniel Borkmann
2024-10-16 13:49 ` [PATCH bpf 2/3] bpf: Fix print_reg_state's constant scalar dump Daniel Borkmann
2024-10-16 20:16 ` Andrii Nakryiko
2024-10-16 13:49 ` [PATCH bpf 3/3] selftests/bpf: Add test case for delta propagation Daniel Borkmann
2024-10-16 21:56 ` Eduard Zingerman
2024-10-16 22:12 ` [PATCH bpf 1/3] bpf: Fix incorrect delta propagation between linked registers Eduard Zingerman
2024-10-17 18:10 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172918863097.2561819.16960201256166830425.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=john.fastabend@gmail.com \
--cc=nathaniel.theis@nccgroup.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox