From: patchwork-bot+netdevbpf@kernel.org
To: Hou Tao <houtao@huaweicloud.com>
Cc: bpf@vger.kernel.org, martin.lau@linux.dev,
alexei.starovoitov@gmail.com, andrii@kernel.org,
eddyz87@gmail.com, song@kernel.org, haoluo@google.com,
yonghong.song@linux.dev, daniel@iogearbox.net,
kpsingh@kernel.org, sdf@fomichev.me, jolsa@kernel.org,
john.fastabend@gmail.com, houtao1@huawei.com,
xukuohai@huawei.com
Subject: Re: [PATCH bpf v3] bpf: Preserve param->string when parsing mount options
Date: Tue, 22 Oct 2024 20:30:30 +0000 [thread overview]
Message-ID: <172962903076.1073819.3858873207115875825.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20241022130133.3798232-1-houtao@huaweicloud.com>
Hello:
This patch was applied to bpf/bpf.git (master)
by Andrii Nakryiko <andrii@kernel.org>:
On Tue, 22 Oct 2024 21:01:33 +0800 you wrote:
> From: Hou Tao <houtao1@huawei.com>
>
> In bpf_parse_param(), keep the value of param->string intact so it can
> be freed later. Otherwise, the kmalloc area pointed to by param->string
> will be leaked as shown below:
>
> unreferenced object 0xffff888118c46d20 (size 8):
> comm "new_name", pid 12109, jiffies 4295580214
> hex dump (first 8 bytes):
> 61 6e 79 00 38 c9 5c 7e any.8.\~
> backtrace (crc e1b7f876):
> [<00000000c6848ac7>] kmemleak_alloc+0x4b/0x80
> [<00000000de9f7d00>] __kmalloc_node_track_caller_noprof+0x36e/0x4a0
> [<000000003e29b886>] memdup_user+0x32/0xa0
> [<0000000007248326>] strndup_user+0x46/0x60
> [<0000000035b3dd29>] __x64_sys_fsconfig+0x368/0x3d0
> [<0000000018657927>] x64_sys_call+0xff/0x9f0
> [<00000000c0cabc95>] do_syscall_64+0x3b/0xc0
> [<000000002f331597>] entry_SYSCALL_64_after_hwframe+0x4b/0x53
>
> [...]
Here is the summary with links:
- [bpf,v3] bpf: Preserve param->string when parsing mount options
https://git.kernel.org/bpf/bpf/c/1f97c03f43fa
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2024-10-22 20:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-22 13:01 [PATCH bpf v3] bpf: Preserve param->string when parsing mount options Hou Tao
2024-10-22 20:30 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172962903076.1073819.3858873207115875825.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=houtao1@huawei.com \
--cc=houtao@huaweicloud.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=martin.lau@linux.dev \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=xukuohai@huawei.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox