BPF List
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel.org
To: Byeonguk Jeong <jungbu2855@gmail.com>
Cc: toke@kernel.org, ast@kernel.org, daniel@iogearbox.net,
	houtao@huaweicloud.com, yonghong.song@linux.dev,
	linux-kernel@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH v2 bpf 1/2] bpf: Fix out-of-bounds write in trie_get_next_key()
Date: Tue, 29 Oct 2024 20:50:29 +0000	[thread overview]
Message-ID: <173023502951.818655.12095228890025333064.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <Zxx384ZfdlFYnz6J@localhost.localdomain>

Hello:

This series was applied to bpf/bpf.git (master)
by Alexei Starovoitov <ast@kernel.org>:

On Sat, 26 Oct 2024 14:02:43 +0900 you wrote:
> trie_get_next_key() allocates a node stack with size trie->max_prefixlen,
> while it writes (trie->max_prefixlen + 1) nodes to the stack when it has
> full paths from the root to leaves. For example, consider a trie with
> max_prefixlen is 8, and the nodes with key 0x00/0, 0x00/1, 0x00/2, ...
> 0x00/8 inserted. Subsequent calls to trie_get_next_key with _key with
> .prefixlen = 8 make 9 nodes be written on the node stack with size 8.
> 
> [...]

Here is the summary with links:
  - [v2,bpf,1/2] bpf: Fix out-of-bounds write in trie_get_next_key()
    https://git.kernel.org/bpf/bpf/c/13400ac8fb80
  - [v2,bpf,2/2] selftests/bpf: Add test for trie_get_next_key()
    https://git.kernel.org/bpf/bpf/c/d7f214aeacb9

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



      parent reply	other threads:[~2024-10-29 20:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-26  5:02 [PATCH v2 bpf 1/2] bpf: Fix out-of-bounds write in trie_get_next_key() Byeonguk Jeong
2024-10-26  5:04 ` [PATCH v2 bpf 2/2] selftests/bpf: Add test for trie_get_next_key() Byeonguk Jeong
2024-10-29  1:33   ` Hou Tao
2024-10-29  1:32 ` [PATCH v2 bpf 1/2] bpf: Fix out-of-bounds write in trie_get_next_key() Hou Tao
2024-10-29 20:50 ` patchwork-bot+netdevbpf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=173023502951.818655.12095228890025333064.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=houtao@huaweicloud.com \
    --cc=jungbu2855@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=toke@kernel.org \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox