public inbox for bpf@vger.kernel.org
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel.org
To: Kumar Kartikeya Dwivedi <memxor@gmail.com>
Cc: bpf@vger.kernel.org, kkd@meta.com, ast@kernel.org,
	andrii@kernel.org, daniel@iogearbox.net, martin.lau@kernel.org,
	eddyz87@gmail.com, kernel-team@fb.com
Subject: Re: [PATCH bpf-next v3 0/3] Handle possible NULL trusted raw_tp arguments
Date: Mon, 04 Nov 2024 19:50:31 +0000	[thread overview]
Message-ID: <173074983101.4192045.14999885368639278804.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20241104171959.2938862-1-memxor@gmail.com>

Hello:

This series was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@kernel.org>:

On Mon,  4 Nov 2024 09:19:56 -0800 you wrote:
> More context is available in [0], but the TLDR; is that the verifier
> incorrectly assumes that any raw tracepoint argument will always be
> non-NULL. This means that even when users correctly check possible NULL
> arguments, the verifier can remove the NULL check due to incorrect
> knowledge of the NULL-ness of the pointer. Secondly, kernel helpers or
> kfuncs taking these trusted tracepoint arguments incorrectly assume that
> all arguments will always be valid non-NULL.
> 
> [...]

Here is the summary with links:
  - [bpf-next,v3,1/3] bpf: Mark raw_tp arguments with PTR_MAYBE_NULL
    https://git.kernel.org/bpf/bpf-next/c/cb4158ce8ec8
  - [bpf-next,v3,2/3] selftests/bpf: Clean up open-coded gettid syscall invocations
    https://git.kernel.org/bpf/bpf-next/c/0e2fb011a0ba
  - [bpf-next,v3,3/3] selftests/bpf: Add tests for raw_tp null handling
    https://git.kernel.org/bpf/bpf-next/c/d798ce3f4cab

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



      parent reply	other threads:[~2024-11-04 19:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-04 17:19 [PATCH bpf-next v3 0/3] Handle possible NULL trusted raw_tp arguments Kumar Kartikeya Dwivedi
2024-11-04 17:19 ` [PATCH bpf-next v3 1/3] bpf: Mark raw_tp arguments with PTR_MAYBE_NULL Kumar Kartikeya Dwivedi
2024-11-06 22:32   ` Andrii Nakryiko
2024-11-06 22:58     ` Kumar Kartikeya Dwivedi
2024-11-08  5:12       ` Alexei Starovoitov
2024-11-04 17:19 ` [PATCH bpf-next v3 2/3] selftests/bpf: Clean up open-coded gettid syscall invocations Kumar Kartikeya Dwivedi
2024-11-04 17:19 ` [PATCH bpf-next v3 3/3] selftests/bpf: Add tests for raw_tp null handling Kumar Kartikeya Dwivedi
2024-11-04 19:50 ` patchwork-bot+netdevbpf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=173074983101.4192045.14999885368639278804.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel.org \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=kernel-team@fb.com \
    --cc=kkd@meta.com \
    --cc=martin.lau@kernel.org \
    --cc=memxor@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox