From: patchwork-bot+netdevbpf@kernel.org
To: =?utf-8?b?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2VuIDx0b2tlQHJlZGhhdC5jb20+?=@aws-us-west-2-korg-oddjob-rhel9-1.codeaurora.org
Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org,
yonghong.song@linux.dev, john.fastabend@gmail.com,
kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com,
jolsa@kernel.org, vmalik@redhat.com, bpf@vger.kernel.org
Subject: Re: [PATCH bpf-next v5] selftests/bpf: Consolidate kernel modules into common directory
Date: Fri, 06 Dec 2024 22:10:31 +0000 [thread overview]
Message-ID: <173352303103.2814043.17875547914996700881.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20241204-bpf-selftests-mod-compile-v5-1-b96231134a49@redhat.com>
Hello:
This patch was applied to bpf/bpf-next.git (master)
by Andrii Nakryiko <andrii@kernel.org>:
On Wed, 04 Dec 2024 14:28:26 +0100 you wrote:
> The selftests build four kernel modules which use copy-pasted Makefile
> targets. This is a bit messy, and doesn't scale so well when we add more
> modules, so let's consolidate these rules into a single rule generated
> for each module name, and move the module sources into a single
> directory.
>
> To avoid parallel builds of the different modules stepping on each
> other's toes during the 'modpost' phase of the Kbuild 'make modules',
> the module files should really be a grouped target. However, make only
> added explicit support for grouped targets in version 4.3, which is
> newer than the minimum version supported by the kernel. However, make
> implicitly treats pattern matching rules with multiple targets as a
> grouped target, so we can work around this by turning the rule into a
> pattern matching target. We do this by replacing '.ko' with '%ko' in the
> targets with subst().
>
> [...]
Here is the summary with links:
- [bpf-next,v5] selftests/bpf: Consolidate kernel modules into common directory
https://git.kernel.org/bpf/bpf-next/c/d6212d82bf26
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
next prev parent reply other threads:[~2024-12-06 22:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 13:28 [PATCH bpf-next v5] selftests/bpf: Consolidate kernel modules into common directory Toke Høiland-Jørgensen
2024-12-06 22:10 ` patchwork-bot+netdevbpf [this message]
2024-12-11 3:03 ` Kumar Kartikeya Dwivedi
2024-12-12 19:26 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173352303103.2814043.17875547914996700881.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc==?utf-8?b?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2VuIDx0b2tlQHJlZGhhdC5jb20+?=@aws-us-west-2-korg-oddjob-rhel9-1.codeaurora.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=martin.lau@linux.dev \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=vmalik@redhat.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox