BPF List
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel.org
To: Mahe Tardy <mahe.tardy@gmail.com>
Cc: bpf@vger.kernel.org, andrii@kernel.org,
	mykyta.yatsenko5@gmail.com, yatsenko@meta.com,
	daniel@iogearbox.net, john.fastabend@gmail.com
Subject: Re: [PATCH bpf-next] selftests/bpf: fix veristat comp mode with new stats
Date: Mon, 30 Dec 2024 23:00:34 +0000	[thread overview]
Message-ID: <173559963401.1460841.1791648471313982173.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20241220152218.28405-1-mahe.tardy@gmail.com>

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@kernel.org>:

On Fri, 20 Dec 2024 15:22:18 +0000 you wrote:
> Commit 82c1f13de315 ("selftests/bpf: Add more stats into veristat")
> introduced new stats, added by default in the CSV output, that were not
> added to parse_stat_value, used in parse_stats_csv which is used in
> comparison mode. Thus it broke comparison mode altogether making it fail
> with "Unrecognized stat #7" and EINVAL.
> 
> One quirk is that PROG_TYPE and ATTACH_TYPE have been transformed to
> strings using libbpf_bpf_prog_type_str and libbpf_bpf_attach_type_str
> respectively. Since we might not want to compare those string values, we
> just skip the parsing in this patch. We might want to translate it back
> to the enum value or compare the string value directly.
> 
> [...]

Here is the summary with links:
  - [bpf-next] selftests/bpf: fix veristat comp mode with new stats
    https://git.kernel.org/bpf/bpf-next/c/9468f39ba478

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



      parent reply	other threads:[~2024-12-30 23:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-20 15:22 [PATCH bpf-next] selftests/bpf: fix veristat comp mode with new stats Mahe Tardy
2024-12-20 15:40 ` Mykyta Yatsenko
2024-12-30 23:00 ` patchwork-bot+netdevbpf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=173559963401.1460841.1791648471313982173.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel.org \
    --cc=andrii@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=john.fastabend@gmail.com \
    --cc=mahe.tardy@gmail.com \
    --cc=mykyta.yatsenko5@gmail.com \
    --cc=yatsenko@meta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox