BPF List
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel.org
To: Yonghong Song <yonghong.song@linux.dev>
Cc: bpf@vger.kernel.org, ast@kernel.org, andrii@kernel.org,
	daniel@iogearbox.net, kernel-team@fb.com, martin.lau@kernel.org,
	linux@jordanrome.com
Subject: Re: [PATCH bpf-next v2 1/2] libbpf: Add unique_match option for multi kprobe
Date: Fri, 10 Jan 2025 21:30:38 +0000	[thread overview]
Message-ID: <173654463802.2209933.16405023988196154444.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20250109174023.3368432-1-yonghong.song@linux.dev>

Hello:

This series was applied to bpf/bpf-next.git (master)
by Andrii Nakryiko <andrii@kernel.org>:

On Thu,  9 Jan 2025 09:40:23 -0800 you wrote:
> Jordan reported an issue in Meta production environment where func
> try_to_wake_up() is renamed to try_to_wake_up.llvm.<hash>() by clang
> compiler at lto mode. The original 'kprobe/try_to_wake_up' does not
> work any more since try_to_wake_up() does not match the actual func
> name in /proc/kallsyms.
> 
> There are a couple of ways to resolve this issue. For example, in
> attach_kprobe(), we could do lookup in /proc/kallsyms so try_to_wake_up()
> can be replaced by try_to_wake_up.llvm.<hach>(). Or we can force users
> to use bpf_program__attach_kprobe() where they need to lookup
> /proc/kallsyms to find out try_to_wake_up.llvm.<hach>(). But these two
> approaches requires extra work by either libbpf or user.
> 
> [...]

Here is the summary with links:
  - [bpf-next,v2,1/2] libbpf: Add unique_match option for multi kprobe
    https://git.kernel.org/bpf/bpf-next/c/e2b0bda62d54
  - [bpf-next,v2,2/2] selftests/bpf: Add a test for kprobe multi with unique_match
    https://git.kernel.org/bpf/bpf-next/c/a43796b52012

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



      parent reply	other threads:[~2025-01-10 21:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-09 17:40 [PATCH bpf-next v2 1/2] libbpf: Add unique_match option for multi kprobe Yonghong Song
2025-01-09 17:40 ` [PATCH bpf-next v2 2/2] selftests/bpf: Add a test for kprobe multi with unique_match Yonghong Song
2025-01-10 21:26 ` [PATCH bpf-next v2 1/2] libbpf: Add unique_match option for multi kprobe Andrii Nakryiko
2025-01-10 21:30 ` patchwork-bot+netdevbpf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=173654463802.2209933.16405023988196154444.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel.org \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=kernel-team@fb.com \
    --cc=linux@jordanrome.com \
    --cc=martin.lau@kernel.org \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox