BPF List
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel.org
To: YiFei Zhu <zhuyifei@google.com>
Cc: bpf@vger.kernel.org, qmo@kernel.org, ast@kernel.org,
	tadakentaso@gmail.com, daniel@iogearbox.net, andrii@kernel.org,
	irogers@google.com, gthelen@google.com, maheshb@google.com,
	minhanhdn@google.com, sharmasagarika@google.com,
	xuanyao@google.com
Subject: Re: [PATCH bpf] bpftool: Fix regression of "bpftool cgroup tree" EINVAL on older kernels
Date: Tue, 06 May 2025 21:10:27 +0000	[thread overview]
Message-ID: <174656582725.1652357.5444508643664724718.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20250428211536.1651456-1-zhuyifei@google.com>

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Andrii Nakryiko <andrii@kernel.org>:

On Mon, 28 Apr 2025 21:15:36 +0000 you wrote:
> If cgroup_has_attached_progs queries an attach type not supported
> by the running kernel, due to the kernel being older than the bpftool
> build, it would encounter an -EINVAL from BPF_PROG_QUERY syscall.
> 
> Prior to commit 98b303c9bf05 ("bpftool: Query only cgroup-related
> attach types"), this EINVAL would be ignored by the function, allowing
> the function to only consider supported attach types. The commit
> changed so that, instead of querying all attach types, only attach
> types from the array `cgroup_attach_types` is queried. The assumption
> is that because these are only cgroup attach types, they should all
> be supported. Unfortunately this assumption may be false when the
> kernel is older than the bpftool build, where the attach types queried
> by bpftool is not yet implemented in the kernel. This would result in
> errors such as:
> 
> [...]

Here is the summary with links:
  - [bpf] bpftool: Fix regression of "bpftool cgroup tree" EINVAL on older kernels
    https://git.kernel.org/bpf/bpf-next/c/43745d11bfd9

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



      parent reply	other threads:[~2025-05-06 21:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-28 21:15 [PATCH bpf] bpftool: Fix regression of "bpftool cgroup tree" EINVAL on older kernels YiFei Zhu
2025-04-29  9:09 ` Quentin Monnet
2025-05-01 17:54 ` Andrii Nakryiko
2025-05-01 20:04   ` Quentin Monnet
2025-05-01 22:30     ` YiFei Zhu
2025-05-06 21:10 ` patchwork-bot+netdevbpf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=174656582725.1652357.5444508643664724718.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel.org \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=gthelen@google.com \
    --cc=irogers@google.com \
    --cc=maheshb@google.com \
    --cc=minhanhdn@google.com \
    --cc=qmo@kernel.org \
    --cc=sharmasagarika@google.com \
    --cc=tadakentaso@gmail.com \
    --cc=xuanyao@google.com \
    --cc=zhuyifei@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox