BPF List
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel.org
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: martin.lau@linux.dev, kuba@kernel.org, bpf@vger.kernel.org,
	netdev@vger.kernel.org, dddddd@hust.edu.cn,
	M202472210@hust.edu.cn, dzm91@hust.edu.cn, willemb@google.com,
	sdf@fomichev.me
Subject: Re: [PATCH bpf] bpf: Do not let BPF test infra emit invalid GSO types to stack
Date: Mon, 20 Oct 2025 20:30:06 +0000	[thread overview]
Message-ID: <176099220626.401229.10029182117746939973.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20251020075441.127980-1-daniel@iogearbox.net>

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Martin KaFai Lau <martin.lau@kernel.org>:

On Mon, 20 Oct 2025 09:54:41 +0200 you wrote:
> Yinhao et al. reported that their fuzzer tool was able to trigger a
> skb_warn_bad_offload() from netif_skb_features() -> gso_features_check().
> When a BPF program - triggered via BPF test infra - pushes the packet
> to the loopback device via bpf_clone_redirect() then mentioned offload
> warning can be seen. GSO-related features are then rightfully disabled.
> 
> We get into this situation due to convert___skb_to_skb() setting
> gso_segs and gso_size but not gso_type. Technically, it makes sense
> that this warning triggers since the GSO properties are malformed due
> to the gso_type. Potentially, the gso_type could be marked non-trustworthy
> through setting it at least to SKB_GSO_DODGY without any other specific
> assumptions, but that also feels wrong given we should not go further
> into the GSO engine in the first place.
> 
> [...]

Here is the summary with links:
  - [bpf] bpf: Do not let BPF test infra emit invalid GSO types to stack
    https://git.kernel.org/bpf/bpf-next/c/04a899573fb8

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



      reply	other threads:[~2025-10-20 20:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-20  7:54 [PATCH bpf] bpf: Do not let BPF test infra emit invalid GSO types to stack Daniel Borkmann
2025-10-20 20:30 ` patchwork-bot+netdevbpf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=176099220626.401229.10029182117746939973.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel.org \
    --cc=M202472210@hust.edu.cn \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=dddddd@hust.edu.cn \
    --cc=dzm91@hust.edu.cn \
    --cc=kuba@kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=netdev@vger.kernel.org \
    --cc=sdf@fomichev.me \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox