From: patchwork-bot+netdevbpf@kernel.org
To: Weiming Shi <bestswngs@gmail.com>
Cc: martin.lau@linux.dev, ast@kernel.org, daniel@iogearbox.net,
andrii@kernel.org, eddyz87@gmail.com, memxor@gmail.com,
song@kernel.org, yonghong.song@linux.dev, jolsa@kernel.org,
roman.gushchin@linux.dev, bpf@vger.kernel.org, xmei5@asu.edu
Subject: Re: [PATCH bpf v2 0/2] bpf: fix end-of-list detection in cgroup_storage_get_next_key()
Date: Mon, 06 Apr 2026 01:50:12 +0000 [thread overview]
Message-ID: <177544021254.2520976.8277446547678258108.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20260403132951.43533-1-bestswngs@gmail.com>
Hello:
This series was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@kernel.org>:
On Fri, 3 Apr 2026 21:29:49 +0800 you wrote:
> list_next_entry() never returns NULL, so the NULL check in
> cgroup_storage_get_next_key() is dead code. When iterating past the last
> element, the function reads storage->key from a bogus pointer that aliases
> internal map fields and copies the result to userspace.
>
> Patch 1 replaces the NULL check with list_entry_is_head() so the function
> correctly returns -ENOENT when there are no more entries.
>
> [...]
Here is the summary with links:
- [bpf,v2,1/2] bpf: fix end-of-list detection in cgroup_storage_get_next_key()
https://git.kernel.org/bpf/bpf-next/c/5828b9e5b272
- [bpf,v2,2/2] selftests/bpf: add get_next_key boundary test for cgroup_storage
https://git.kernel.org/bpf/bpf-next/c/262b857da6be
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2026-04-06 1:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-03 13:29 [PATCH bpf v2 0/2] bpf: fix end-of-list detection in cgroup_storage_get_next_key() Weiming Shi
2026-04-03 13:29 ` [PATCH bpf v2 1/2] " Weiming Shi
2026-04-03 13:29 ` [PATCH bpf v2 2/2] selftests/bpf: add get_next_key boundary test for cgroup_storage Weiming Shi
2026-04-03 14:16 ` Paul Chaignon
2026-04-06 1:50 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177544021254.2520976.8277446547678258108.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bestswngs@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=jolsa@kernel.org \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=roman.gushchin@linux.dev \
--cc=song@kernel.org \
--cc=xmei5@asu.edu \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox