public inbox for bpf@vger.kernel.org
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel.org
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: bpf@vger.kernel.org, ast@kernel.org, eddyz87@gmail.com, info@starlabs.sg
Subject: Re: [PATCH bpf-next 1/2] bpf: Enforce regsafe base id consistency for BPF_ADD_CONST scalars
Date: Sat, 11 Apr 2026 01:20:06 +0000	[thread overview]
Message-ID: <177587040680.2708733.16822135192644626939.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20260410232651.559778-1-daniel@iogearbox.net>

Hello:

This series was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@kernel.org>:

On Sat, 11 Apr 2026 01:26:50 +0200 you wrote:
> When regsafe() compares two scalar registers that both carry
> BPF_ADD_CONST, check_scalar_ids() maps their full compound id
> (aka base | BPF_ADD_CONST flag) as one idmap entry. However,
> it never verifies that the underlying base ids, that is, with
> the flag stripped are consistent with existing idmap mappings.
> 
> This allows construction of two verifier states where the old
> state has R3 = R2 + 10 (both sharing base id A) while the current
> state has R3 = R4 + 10 (base id C, unrelated to R2). The idmap
> creates two independent entries: A->B (for R2) and A|flag->C|flag
> (for R3), without catching that A->C conflicts with A->B. State
> pruning then incorrectly succeeds.
> 
> [...]

Here is the summary with links:
  - [bpf-next,1/2] bpf: Enforce regsafe base id consistency for BPF_ADD_CONST scalars
    https://git.kernel.org/bpf/bpf-next/c/2f2ec8e7730e
  - [bpf-next,2/2] selftests/bpf: Add test for add_const base_id consistency
    https://git.kernel.org/bpf/bpf-next/c/497fa510ee46

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



      parent reply	other threads:[~2026-04-11  1:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-10 23:26 [PATCH bpf-next 1/2] bpf: Enforce regsafe base id consistency for BPF_ADD_CONST scalars Daniel Borkmann
2026-04-10 23:26 ` [PATCH bpf-next 2/2] selftests/bpf: Add test for add_const base_id consistency Daniel Borkmann
2026-04-11  1:20 ` patchwork-bot+netdevbpf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=177587040680.2708733.16822135192644626939.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=info@starlabs.sg \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox