From: patchwork-bot+netdevbpf@kernel.org
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: ast@kernel.org, memxor@gmail.com, yusuke.suzuki@isovalent.com,
tom.hadlaw@isovalent.com, bpf@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH bpf 1/2] bpf: Fix bpf_skb_change_tail wrt csum partial skbs
Date: Tue, 08 Sep 2026 02:40:04 +0000 [thread overview]
Message-ID: <178883520489.3252445.12614070456129437426.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20260907121025.1923656-1-daniel@iogearbox.net>
Hello:
This series was applied to bpf/bpf.git (master)
by Alexei Starovoitov <ast@kernel.org>:
On Mon, 7 Sep 2026 14:10:24 +0200 you wrote:
> Cilium generates ICMP "frag needed" replies from BPF when a LB DSR
> packet exceeds the egress MTU. The reply is built by first trimming the
> packet down to target size via bpf_skb_change_tail(), and then pushing
> the ICMP error headers in front of it.
>
> The trim is rejected for skbs which carry a checksum offload, e.g. TCP
> packets aggregated by GRO on ingress where tcp_gro_complete() leaves
> the skb as CHECKSUM_PARTIAL. __bpf_skb_min_len() raises the minimum
> length to the end of the L4 checksum field, so a trim to 42 bytes bails
> out with -EINVAL given a min_len of 52 in this case, and due to that
> the ICMP generator fails. This is not the case if GRO is turned off.
>
> [...]
Here is the summary with links:
- [bpf,1/2] bpf: Fix bpf_skb_change_tail wrt csum partial skbs
https://git.kernel.org/bpf/bpf/c/3b55f350c68a
- [bpf,2/2] selftests/bpf: Add test for bpf_skb_change_tail on csum partial skbs
https://git.kernel.org/bpf/bpf/c/15e2565f1c43
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2026-09-08 2:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-07 12:10 [PATCH bpf 1/2] bpf: Fix bpf_skb_change_tail wrt csum partial skbs Daniel Borkmann
2026-09-07 12:10 ` [PATCH bpf 2/2] selftests/bpf: Add test for bpf_skb_change_tail on " Daniel Borkmann
2026-09-07 12:24 ` [PATCH bpf 1/2] bpf: Fix bpf_skb_change_tail wrt " sashiko-bot
2026-09-07 12:41 ` Daniel Borkmann
2026-09-08 2:40 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178883520489.3252445.12614070456129437426.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=memxor@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=tom.hadlaw@isovalent.com \
--cc=yusuke.suzuki@isovalent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).