From: wangyufen <wangyufen@huawei.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: <ast@kernel.org>, <daniel@iogearbox.net>, <andrii@kernel.org>,
<martin.lau@linux.dev>, <song@kernel.org>, <yhs@fb.com>,
<john.fastabend@gmail.com>, <kpsingh@kernel.org>,
<sdf@google.com>, <haoluo@google.com>, <jolsa@kernel.org>,
<mykolal@fb.com>, <shuah@kernel.org>, <delyank@fb.com>,
<zhudi2@huawei.com>, <jakub@cloudflare.com>, <kuba@kernel.org>,
<kuifeng@fb.com>, <deso@posteo.net>, <zhuyifei@google.com>,
<hengqi.chen@gmail.com>, <bpf@vger.kernel.org>
Subject: Re: [bpf-next 00/11] bpf/selftests: convert some tests to ASSERT_* macros
Date: Thu, 29 Sep 2022 11:37:39 +0800 [thread overview]
Message-ID: <17cd848b-d8c8-aadc-c1d8-9620b1a4440d@huawei.com> (raw)
In-Reply-To: <CAEf4BzY4GARZ7C+rYDuCHAbMRrC=Fx7eVSBZ60txme97it2FLg@mail.gmail.com>
在 2022/9/29 8:37, Andrii Nakryiko 写道:
> On Sun, Sep 25, 2022 at 9:51 PM Wang Yufen <wangyufen@huawei.com> wrote:
>> Convert some tests to use the preferred ASSERT_* macros instead of the
>> deprecated CHECK().
>>
>> Wang Yufen (11):
>> bpf/selftests: convert sockmap_basic test to ASSERT_* macros
>> bpf/selftests: convert sockmap_ktls test to ASSERT_* macros
>> bpf/selftests: convert sockopt test to ASSERT_* macros
>> bpf/selftests: convert sockopt_inherit test to ASSERT_* macros
>> bpf/selftests: convert sockopt_multi test to ASSERT_* macros
>> bpf/selftests: convert sockopt_sk test to ASSERT_* macros
>> bpf/selftests: convert tcp_estats test to ASSERT_* macros
>> bpf/selftests: convert tcp_hdr_options test to ASSERT_* macros
>> bpf/selftests: convert tcp_rtt test to ASSERT_* macros
>> bpf/selftests: convert tcpbpf_user test to ASSERT_* macros
>> bpf/selftests: convert udp_limit test to ASSERT_* macros
>>
>> .../selftests/bpf/prog_tests/sockmap_basic.c | 87 ++++++++--------------
>> .../selftests/bpf/prog_tests/sockmap_ktls.c | 39 +++-------
>> tools/testing/selftests/bpf/prog_tests/sockopt.c | 4 +-
>> .../selftests/bpf/prog_tests/sockopt_inherit.c | 30 ++++----
>> .../selftests/bpf/prog_tests/sockopt_multi.c | 10 +--
>> .../testing/selftests/bpf/prog_tests/sockopt_sk.c | 2 +-
>> .../testing/selftests/bpf/prog_tests/tcp_estats.c | 4 +-
>> .../selftests/bpf/prog_tests/tcp_hdr_options.c | 80 +++++++-------------
>> tools/testing/selftests/bpf/prog_tests/tcp_rtt.c | 13 ++--
>> .../testing/selftests/bpf/prog_tests/tcpbpf_user.c | 32 +++-----
>> tools/testing/selftests/bpf/prog_tests/udp_limit.c | 18 ++---
>> 11 files changed, 117 insertions(+), 202 deletions(-)
>>
>> --
>> 1.8.3.1
>>
> Thanks for the clean up! I've changed one ASSERT_OK(err && errno !=
> ENOENT) to ASSERT_EQ(errno, ENOENT) in patch #1, that expresses the
> intent more directly. Please also keep in mind that patch prefix
> should (conventionally) be "selftests/bpf: ". I've fixed that for all
> patches while applying.
I got it.Thanks for the fixes.
>
> We are down to:
>
> $ rg -w CHECK | wc -l
> 1186
> 09/28 17:36:39.381
> andriin@devbig019:~/linux/tools/testing/selftests/bpf (master)
> $ rg -w CHECK_FAIL | wc -l
> 463
>
> Some ways to go still, but slowly decreasing. Thank you for your contribution!
next prev parent reply other threads:[~2022-09-29 3:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 5:12 [bpf-next 00/11] bpf/selftests: convert some tests to ASSERT_* macros Wang Yufen
2022-09-26 5:12 ` [bpf-next 01/11] bpf/selftests: convert sockmap_basic test " Wang Yufen
2022-09-26 5:12 ` [bpf-next 02/11] bpf/selftests: convert sockmap_ktls " Wang Yufen
2022-09-26 5:12 ` [bpf-next 03/11] bpf/selftests: convert sockopt " Wang Yufen
2022-09-26 5:12 ` [bpf-next 04/11] bpf/selftests: convert sockopt_inherit " Wang Yufen
2022-09-26 5:12 ` [bpf-next 05/11] bpf/selftests: convert sockopt_multi " Wang Yufen
2022-09-26 5:12 ` [bpf-next 06/11] bpf/selftests: convert sockopt_sk " Wang Yufen
2022-09-26 5:12 ` [bpf-next 07/11] bpf/selftests: convert tcp_estats " Wang Yufen
2022-09-26 5:12 ` [bpf-next 08/11] bpf/selftests: convert tcp_hdr_options " Wang Yufen
2022-11-04 1:29 ` Martin KaFai Lau
2022-09-26 5:12 ` [bpf-next 09/11] bpf/selftests: convert tcp_rtt " Wang Yufen
2022-09-26 5:12 ` [bpf-next 10/11] bpf/selftests: convert tcpbpf_user " Wang Yufen
2022-09-26 5:12 ` [bpf-next 11/11] bpf/selftests: convert udp_limit " Wang Yufen
2022-09-29 0:37 ` [bpf-next 00/11] bpf/selftests: convert some tests " Andrii Nakryiko
2022-09-29 3:37 ` wangyufen [this message]
2022-09-29 0:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17cd848b-d8c8-aadc-c1d8-9620b1a4440d@huawei.com \
--to=wangyufen@huawei.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=delyank@fb.com \
--cc=deso@posteo.net \
--cc=haoluo@google.com \
--cc=hengqi.chen@gmail.com \
--cc=jakub@cloudflare.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=kuifeng@fb.com \
--cc=martin.lau@linux.dev \
--cc=mykolal@fb.com \
--cc=sdf@google.com \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=yhs@fb.com \
--cc=zhudi2@huawei.com \
--cc=zhuyifei@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox