Re: [PATCH 3/4] selftests/bpf: impose global ordering for test decl_tags

[Eduard Zingerman <eddyz87@gmail.com>]

On Mon, 2026-03-30 at 16:30 +0100, Puranjay Mohan wrote:
> Eduard Zingerman <eddyz87@gmail.com> writes:
> 
> > Impose global ordering for all decl tags used by test_loader.c based
> > tests (__success, __failure, __msg, etc):
> > - change every tag to expand as
> >   __attribute__((btf_decl_tag("comment:" XSTR(__COUNTER__) ...)))
> > - change parse_test_spec() to collect all decl tags before
> >   processing and sort them using strverscmp().
> > 
> > The ordering is necessary for gcc-bpf.
> > Neither GCC nor the C standard defines the order in which function
> > attributes are consumed. While Clang tends to preserve definition order,
> > GCC may process them out of sequence. This inconsistency causes BPF
> > tests with multiple __msg entries to fail when compiled with GCC.
> > 
> > Co-developed-by: Cupertino Miranda <cupertino.miranda@oracle.com>
> > Signed-off-by: Eduard Zingerman <eddyz87@gmail.com>
> 
> Checkpatch warns about this:
> 
> WARNING: Co-developed-by and Signed-off-by: name/email do not match
> #19:
> Co-developed-by: Cupertino Miranda <cupertino.miranda@oracle.com>
> Signed-off-by: Eduard Zingerman <eddyz87@gmail.com>
> 
> Add: 
> Signed-off-by: Cupertino Miranda <cupertino.miranda@oracle.com>
> to fix this.

Ack, thank you

[...]