From: "Enrico Weigelt, metux IT consult" <lkml@metux.net>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
"Enrico Weigelt, metux IT consult" <info@metux.net>
Cc: linux-kernel@vger.kernel.org, pmladek@suse.com,
rostedt@goodmis.org, sergey.senozhatsky@gmail.com,
linux@rasmusvillemoes.dk, kafai@fb.com, songliubraving@fb.com,
yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org,
netdev@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH] lib: vsprintf: check for NULL device_node name in device_node_string()
Date: Tue, 23 Feb 2021 20:54:16 +0100 [thread overview]
Message-ID: <1a010bef-4b13-06ea-e153-e76c4afe0ad1@metux.net> (raw)
In-Reply-To: <YC0fCAp6wxJfizD7@smile.fi.intel.com>
On 17.02.21 14:50, Andy Shevchenko wrote:
> On Wed, Feb 17, 2021 at 01:15:43PM +0100, Enrico Weigelt, metux IT consult wrote:
>> Under rare circumstances it may happen that a device node's name is NULL
>> (most likely kernel bug in some other place).
>
> What circumstances? How can I reproduce this? More information, please!
Observed it when applying a broken overlay. (sorry, didn't keep that
broken code :o). In this case, the device_node was left without a name
(pointing to NULL).
>> + pr_warn("device_node without name. Kernel bug ?\n");
>
> If it's not once, then it's possible to have log spammed with this, right?
It only has occoured once for me. I don't think spamming could happen,
unless one's hacking deeply in the oftree code.
>> + p = "<NULL>";
>
> We have different standard de facto for NULL pointers to be printed. Actually
> if you wish, you may gather them under one definition (maybe somewhere under
> printk) and export to everybody to use.
Seen it in Petr's reply ... going to use that in v2.
--mtx
--
---
Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert
werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren
GPG/PGP-Schlüssel zu.
---
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287
next prev parent reply other threads:[~2021-02-23 20:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-17 12:15 [PATCH] lib: vsprintf: check for NULL device_node name in device_node_string() Enrico Weigelt, metux IT consult
2021-02-17 13:50 ` Andy Shevchenko
2021-02-18 12:53 ` Petr Mladek
2021-02-23 19:54 ` Enrico Weigelt, metux IT consult
2021-02-23 19:54 ` Enrico Weigelt, metux IT consult [this message]
2021-02-18 0:47 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a010bef-4b13-06ea-e153-e76c4afe0ad1@metux.net \
--to=lkml@metux.net \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bpf@vger.kernel.org \
--cc=info@metux.net \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=netdev@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox