From: Eduard Zingerman <eddyz87@gmail.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: bpf <bpf@vger.kernel.org>, Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@kernel.org>,
Kumar Kartikeya Dwivedi <memxor@gmail.com>,
Kernel Team <kernel-team@fb.com>
Subject: Re: [PATCH bpf-next 2/4] bpf: Track delta between "linked" registers.
Date: Mon, 10 Jun 2024 14:51:59 -0700 [thread overview]
Message-ID: <1afca090c23866f25a5b17ebb2df25171ea9c292.camel@gmail.com> (raw)
In-Reply-To: <CAADnVQLEGMvA_hNDZ4F-_ZBdbBR=ZYKmQ7cNayLOrYg2GSRJxw@mail.gmail.com>
On Mon, 2024-06-10 at 13:31 -0700, Alexei Starovoitov wrote:
[...]
> I missed mark_precise_scalar_ids() that needs to match
> what find_equal_scalars() is doing.
>
> What's broken in there?
Sorry, missed this question, here is the link:
https://lore.kernel.org/bpf/20240222005005.31784-3-eddyz87@gmail.com/
TLDR: whole function is wrong (only handles a subset of possible situations).
next prev parent reply other threads:[~2024-06-10 21:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-08 0:44 [PATCH bpf-next 0/4] bpf: Track delta between "linked" registers Alexei Starovoitov
2024-06-08 0:44 ` [PATCH bpf-next 1/4] bpf: Relax tuple len requirement for sk helpers Alexei Starovoitov
2024-06-08 0:44 ` [PATCH bpf-next 2/4] bpf: Track delta between "linked" registers Alexei Starovoitov
2024-06-10 18:32 ` Eduard Zingerman
2024-06-10 18:56 ` Eduard Zingerman
2024-06-10 20:31 ` Alexei Starovoitov
2024-06-10 21:51 ` Eduard Zingerman [this message]
2024-06-10 20:27 ` Alexei Starovoitov
2024-06-10 21:25 ` Alexei Starovoitov
2024-06-08 0:44 ` [PATCH bpf-next 3/4] bpf: Support can_loop/cond_break on big endian Alexei Starovoitov
2024-06-10 5:44 ` Yonghong Song
2024-06-08 0:44 ` [PATCH bpf-next 4/4] selftests/bpf: Add tests for add_const Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1afca090c23866f25a5b17ebb2df25171ea9c292.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=martin.lau@kernel.org \
--cc=memxor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox