Re: [PATCH bpf-next v5 3/8] bpf: Create links for BPF struct_ops maps.

kernel test robot
2023-03-08T16:06:44Z

Hi Kui-Feng,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on bpf-next/master]

url: https://github.com/intel-lab-lkp/linux/commits/Kui-Feng-Lee/bpf-Retire-the-struct_ops-map-kvalue-refcnt/20230308-085434
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
patch link: https://lore.kernel.org/r/20230308005050.255859-4-kuifeng%40meta.com
patch subject: [PATCH bpf-next v5 3/8] bpf: Create links for BPF struct_ops maps.
config: x86_64-defconfig (https://download.01.org/0day-ci/archive/20230308/202303082340.qYFHo45I-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
# https://github.com/intel-lab-lkp/linux/commit/de9e43a5ac82dde718d80d8347e867a8fc935e0a
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Kui-Feng-Lee/bpf-Retire-the-struct_ops-map-kvalue-refcnt/20230308-085434
git checkout de9e43a5ac82dde718d80d8347e867a8fc935e0a
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=x86_64 olddefconfig
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303082340.qYFHo45I-lkp@intel.com/

All errors (new ones prefixed by >>):

In file included from drivers/net/virtio_net.c:13:
>> include/linux/bpf.h:2388:19: error: redefinition of 'bpf_struct_ops_link_create'
2388 | static inline int bpf_struct_ops_link_create(union bpf_attr *attr)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/bpf.h:1592:19: note: previous definition of 'bpf_struct_ops_link_create' with type 'int(union bpf_attr *)'
1592 | static inline int bpf_struct_ops_link_create(union bpf_attr *attr)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
--
In file included from include/linux/filter.h:9,
from include/net/sock_reuseport.h:5,
from include/net/tcp.h:35,
from net/ipv4/netfilter/nf_reject_ipv4.c:8:
>> include/linux/bpf.h:2388:19: error: redefinition of 'bpf_struct_ops_link_create'
2388 | static inline int bpf_struct_ops_link_create(union bpf_attr *attr)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/bpf.h:1592:19: note: previous definition of 'bpf_struct_ops_link_create' with type 'int(union bpf_attr *)'
1592 | static inline int bpf_struct_ops_link_create(union bpf_attr *attr)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
net/ipv4/netfilter/nf_reject_ipv4.c: In function 'nf_send_reset':
net/ipv4/netfilter/nf_reject_ipv4.c:244:23: warning: variable 'niph' set but not used [-Wunused-but-set-variable]
244 | struct iphdr *niph;
| ^~~~
--
In file included from include/linux/filter.h:9,
from kernel/bpf/core.c:21:
>> include/linux/bpf.h:2388:19: error: redefinition of 'bpf_struct_ops_link_create'
2388 | static inline int bpf_struct_ops_link_create(union bpf_attr *attr)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/bpf.h:1592:19: note: previous definition of 'bpf_struct_ops_link_create' with type 'int(union bpf_attr *)'
1592 | static inline int bpf_struct_ops_link_create(union bpf_attr *attr)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/bpf/core.c:1632:12: warning: no previous prototype for 'bpf_probe_read_kernel' [-Wmissing-prototypes]
1632 | u64 __weak bpf_probe_read_kernel(void *dst, u32 size, const void *unsafe_ptr)
| ^~~~~~~~~~~~~~~~~~~~~
kernel/bpf/core.c:2069:6: warning: no previous prototype for 'bpf_patch_call_args' [-Wmissing-prototypes]
2069 | void bpf_patch_call_args(struct bpf_insn *insn, u32 stack_depth)
| ^~~~~~~~~~~~~~~~~~~
--
In file included from include/linux/filter.h:9,
from kernel/kallsyms.c:25:
>> include/linux/bpf.h:2388:19: error: redefinition of 'bpf_struct_ops_link_create'
2388 | static inline int bpf_struct_ops_link_create(union bpf_attr *attr)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/bpf.h:1592:19: note: previous definition of 'bpf_struct_ops_link_create' with type 'int(union bpf_attr *)'
1592 | static inline int bpf_struct_ops_link_create(union bpf_attr *attr)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/kallsyms.c:663:12: warning: no previous prototype for 'arch_get_kallsym' [-Wmissing-prototypes]
663 | int __weak arch_get_kallsym(unsigned int symnum, unsigned long *value,
| ^~~~~~~~~~~~~~~~
--
In file included from include/linux/bpf-cgroup.h:5,
from net/socket.c:55:
>> include/linux/bpf.h:2388:19: error: redefinition of 'bpf_struct_ops_link_create'
2388 | static inline int bpf_struct_ops_link_create(union bpf_attr *attr)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/bpf.h:1592:19: note: previous definition of 'bpf_struct_ops_link_create' with type 'int(union bpf_attr *)'
1592 | static inline int bpf_struct_ops_link_create(union bpf_attr *attr)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
net/socket.c: In function '__sys_getsockopt':
net/socket.c:2300:13: warning: variable 'max_optlen' set but not used [-Wunused-but-set-variable]
2300 | int max_optlen;
| ^~~~~~~~~~
--
In file included from net/ipv6/ip6_fib.c:18:
>> include/linux/bpf.h:2388:19: error: redefinition of 'bpf_struct_ops_link_create'
2388 | static inline int bpf_struct_ops_link_create(union bpf_attr *attr)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/bpf.h:1592:19: note: previous definition of 'bpf_struct_ops_link_create' with type 'int(union bpf_attr *)'
1592 | static inline int bpf_struct_ops_link_create(union bpf_attr *attr)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
net/ipv6/ip6_fib.c: In function 'fib6_add':
net/ipv6/ip6_fib.c:1378:32: warning: variable 'pn' set but not used [-Wunused-but-set-variable]
1378 | struct fib6_node *fn, *pn = NULL;
| ^~
--
In file included from include/linux/filter.h:9,
from include/net/sock_reuseport.h:5,
from include/net/tcp.h:35,
from include/linux/netfilter_ipv6.h:11,
from net/ipv6/netfilter/nf_reject_ipv6.c:12:
>> include/linux/bpf.h:2388:19: error: redefinition of 'bpf_struct_ops_link_create'
2388 | static inline int bpf_struct_ops_link_create(union bpf_attr *attr)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/bpf.h:1592:19: note: previous definition of 'bpf_struct_ops_link_create' with type 'int(union bpf_attr *)'
1592 | static inline int bpf_struct_ops_link_create(union bpf_attr *attr)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
net/ipv6/netfilter/nf_reject_ipv6.c: In function 'nf_send_reset6':
net/ipv6/netfilter/nf_reject_ipv6.c:287:25: warning: variable 'ip6h' set but not used [-Wunused-but-set-variable]
287 | struct ipv6hdr *ip6h;
| ^~~~

vim +/bpf_struct_ops_link_create +2388 include/linux/bpf.h

2387
> 2388 static inline int bpf_struct_ops_link_create(union bpf_attr *attr)
2389 {
2390 return -EOPNOTSUPP;
2391 }
2392

--
0-DAY CI Kernel Test Service