From: Yonghong Song <yhs@fb.com>
To: Ben Hutchings <benh@debian.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>
Cc: <bpf@vger.kernel.org>, <debian-kernel@lists.debian.org>
Subject: Re: [PATCH] bpftool: Fix version string in recursive builds
Date: Fri, 14 Aug 2020 08:43:54 -0700 [thread overview]
Message-ID: <1c00ee1f-5103-e8ec-7953-e09a1c0de707@fb.com> (raw)
In-Reply-To: <20200813235837.GA497088@decadent.org.uk>
On 8/13/20 4:58 PM, Ben Hutchings wrote:
> When bpftool is built as part of a Debian package build, which itself
> uses make, "bpftool version" shows:
>
> bpftool vmake[4]: Entering directory /build/linux-5.8/tools/bpf/bpftool 5.8.8.0 make[4]: Leaving directory /build/linux-5.8
>
> Although we pass the "--no-print-directory" option, this is overridden
> by the environment variable "MAKEFLAGS=w". Clear MAKEFLAGS for the
> "make kernelversion" command.
>
> I have no explanation for the doubled ".8" in the version string, but
> this seems to fix that as well.
>
> Signed-off-by: Ben Hutchings <benh@debian.org>
> ---
> tools/bpf/bpftool/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/bpf/bpftool/Makefile b/tools/bpf/bpftool/Makefile
> index 9e85f101be85..7fbad8cbd171 100644
> --- a/tools/bpf/bpftool/Makefile
> +++ b/tools/bpf/bpftool/Makefile
> @@ -25,7 +25,7 @@ endif
>
> LIBBPF = $(LIBBPF_PATH)libbpf.a
>
> -BPFTOOL_VERSION := $(shell make -rR --no-print-directory -sC ../../.. kernelversion)
> +BPFTOOL_VERSION := $(shell MAKEFLAGS= make -rR --no-print-directory -sC ../../.. kernelversion)
I tried the following
--- a/tools/bpf/bpftool/Makefile
+++ b/tools/bpf/bpftool/Makefile
@@ -25,7 +25,7 @@ endif
LIBBPF = $(LIBBPF_PATH)libbpf.a
-BPFTOOL_VERSION := $(shell make -rR --no-print-directory -sC ../../..
kernelversion)
+BPFTOOL_VERSION := $(shell MAKEFLAGS=w make -rR --no-print-directory
-sC ../../.. kernelversion)
-bash-4.4$ ./bpftool version
./bpftool v5.8.0
I set env variable MAKEFLAGS=w, and build bpftool it works fine too.
Maybe I miss something or debian changed top level Makefile?
I am testing against latest bpf tree.
>
> $(LIBBPF): FORCE
> $(if $(LIBBPF_OUTPUT),@mkdir -p $(LIBBPF_OUTPUT))
>
next prev parent reply other threads:[~2020-08-14 15:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-13 23:58 [PATCH] bpftool: Fix version string in recursive builds Ben Hutchings
2020-08-14 15:43 ` Yonghong Song [this message]
2020-08-14 22:17 ` Ben Hutchings
2020-08-14 22:55 ` Yonghong Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c00ee1f-5103-e8ec-7953-e09a1c0de707@fb.com \
--to=yhs@fb.com \
--cc=ast@kernel.org \
--cc=benh@debian.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=debian-kernel@lists.debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox