BPF List
 help / color / mirror / Atom feed
From: Akira Yokosawa <akiyks@gmail.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: andrii@kernel.org, ast@kernel.org, bagasdotme@gmail.com,
	bpf@vger.kernel.org, corbet@lwn.net, daniel@iogearbox.net,
	haoluo@google.com, john.fastabend@gmail.com, jolsa@kernel.org,
	kpsingh@kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, martin.lau@linux.dev,
	memxor@gmail.com, sdf@google.com, song@kernel.org,
	void@manifault.com, yhs@fb.com, Akira Yokosawa <akiyks@gmail.com>
Subject: Re: [PATCH bpf-next] Documentation: bpf: escape underscore in BPF type name prefix
Date: Sat, 5 Nov 2022 09:05:42 +0900	[thread overview]
Message-ID: <1c8a0445-ee7d-991a-2ec8-cdc29204c68a@gmail.com> (raw)
In-Reply-To: <CAEf4Bzau0QuBiNsXoMq_QRV+_MTyodQsvW7O2kbScgmVmbuXkQ@mail.gmail.com>

Hi,

On Fri, 4 Nov 2022 16:11:10 -0700, Andrii Nakryiko wrote:
[...]
> Applied, thanks. But would the other similar case be problematic?
> 
> $ rg 'bpf_\b'
> bpf_design_QA.rst
> 329:NOTE: BPF subsystem specially reserves the 'bpf_' prefix for type names, in
> 331:avoid defining types with 'bpf_' prefix to not be broken in future
> releases. In
> 333:with 'bpf_' prefix.
> 
> libbpf/libbpf_naming_convention.rst
> 12:following prefixes: ``bpf_``, ``btf_``, ``libbpf_``, ``btf_dump_``,
> 59:described above should have ``libbpf_`` prefix, e.g.

Those other cases are all inside double back quotes and
construct "inline literal" strings. So they are fine.

Which means Bagas could have used the "inline literal" approach
instead.

Regards,
Akira


  reply	other threads:[~2022-11-05  0:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-04 12:39 [PATCH bpf-next] Documentation: bpf: escape underscore in BPF type name prefix Bagas Sanjaya
2022-11-04 13:16 ` KP Singh
2022-11-04 15:05 ` David Vernet
2022-11-04 23:11 ` Andrii Nakryiko
2022-11-05  0:05   ` Akira Yokosawa [this message]
2022-11-05  2:49     ` Bagas Sanjaya
2022-11-04 23:20 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1c8a0445-ee7d-991a-2ec8-cdc29204c68a@gmail.com \
    --to=akiyks@gmail.com \
    --cc=andrii.nakryiko@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bagasdotme@gmail.com \
    --cc=bpf@vger.kernel.org \
    --cc=corbet@lwn.net \
    --cc=daniel@iogearbox.net \
    --cc=haoluo@google.com \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kpsingh@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=memxor@gmail.com \
    --cc=sdf@google.com \
    --cc=song@kernel.org \
    --cc=void@manifault.com \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox