From: Yonghong Song <yhs@fb.com>
To: Song Liu <songliubraving@fb.com>, <bpf@vger.kernel.org>,
<netdev@vger.kernel.org>
Cc: <kernel-team@fb.com>, <ast@kernel.org>, <daniel@iogearbox.net>,
<andrii@kernel.org>, <kpsingh@chromium.org>,
<john.fastabend@gmail.com>
Subject: Re: [PATCH bpf-next] bpf: simplify task_file_seq_get_next()
Date: Fri, 20 Nov 2020 08:57:55 -0800 [thread overview]
Message-ID: <1c8b7242-7236-b3ce-a0f2-c2fe651ab079@fb.com> (raw)
In-Reply-To: <20201120002833.2481110-1-songliubraving@fb.com>
On 11/19/20 4:28 PM, Song Liu wrote:
> Simplify task_file_seq_get_next() by removing two in/out arguments: task
> and fstruct. Use info->task and info->files instead.
>
> Cc: Yonghong Song <yhs@fb.com>
> Signed-off-by: Song Liu <songliubraving@fb.com>
Thanks for the refactor. The new code is shorter and cleaner.
Acked-by: Yonghong Song <yhs@fb.com>
> ---
> kernel/bpf/task_iter.c | 53 ++++++++++++++----------------------------
> 1 file changed, 17 insertions(+), 36 deletions(-)
next prev parent reply other threads:[~2020-11-20 16:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-20 0:28 [PATCH bpf-next] bpf: simplify task_file_seq_get_next() Song Liu
2020-11-20 16:57 ` Yonghong Song [this message]
2020-11-20 22:19 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c8b7242-7236-b3ce-a0f2-c2fe651ab079@fb.com \
--to=yhs@fb.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=kernel-team@fb.com \
--cc=kpsingh@chromium.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox