From: Florian Fainelli <f.fainelli@gmail.com>
To: patchwork-bot+netdevbpf@kernel.org
Cc: bpf@vger.kernel.org, andrii@kernel.org, ast@kernel.org,
daniel@iogearbox.net, martin.lau@linux.dev, song@kernel.org,
yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org,
sdf@google.com, haoluo@google.com, jolsa@kernel.org,
davemarchevsky@fb.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] libbpf: Initialize err in probe_map_create
Date: Wed, 31 Aug 2022 14:50:51 -0700 [thread overview]
Message-ID: <1d5510f7-7c2d-6e30-f5d9-e45c470c380a@gmail.com> (raw)
In-Reply-To: <165964981402.20332.403823292048774488.git-patchwork-notify@kernel.org>
On 8/4/2022 2:50 PM, patchwork-bot+netdevbpf@kernel.org wrote:
> Hello:
>
> This patch was applied to bpf/bpf-next.git (master)
> by Andrii Nakryiko <andrii@kernel.org>:
>
> On Sun, 31 Jul 2022 19:51:09 -0700 you wrote:
>> GCC-11 warns about the possibly unitialized err variable in
>> probe_map_create:
>>
>> libbpf_probes.c: In function 'probe_map_create':
>> libbpf_probes.c:361:38: error: 'err' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>> 361 | return fd < 0 && err == exp_err ? 1 : 0;
>> | ~~~~^~~~~~~~~~
>>
>> [...]
>
> Here is the summary with links:
> - libbpf: Initialize err in probe_map_create
> https://git.kernel.org/bpf/bpf-next/c/3045f42a6432
>
> You are awesome, thank you!
Thanks for applying, I was sort of expecting this patch to land to Linus
a bit quicker, as far as I can see it is still only in linux-next yet it
does fix a build warning turned error. Any chance of fast tracking it?
Thanks!
--
Florian
prev parent reply other threads:[~2022-08-31 21:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-01 2:51 [PATCH] libbpf: Initialize err in probe_map_create Florian Fainelli
2022-08-01 16:25 ` Jiri Olsa
2022-08-04 21:50 ` patchwork-bot+netdevbpf
2022-08-31 21:50 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d5510f7-7c2d-6e30-f5d9-e45c470c380a@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davemarchevsky@fb.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=patchwork-bot+netdevbpf@kernel.org \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox