From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f42.google.com (mail-pj2-f42.google.com [74.125.227.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6698E3DDB04 for ; Thu, 24 Sep 2026 07:11:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790233877; cv=none; b=LsVWYyssFMOjJ8fEbA3sUF3zftMkv3je1xkzoci4fHdZXHO0JE2RFL3WPW+bV1G2MxLUQ3IDRj6IGD/mFYBRn9tJhO+jcxi25K1U47mMF0W9xu8wuZiEr+k7s2t48ZxvmEslgTY6GZTsp3WPLL2JnK71WMUql0O6hzI0LhwXxVY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790233877; c=relaxed/simple; bh=ZuEmG6wBl2efC/945xSQ8zaEHszttX3U0I2BPYqa8Dk=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=QrccEOcq3/jlcTjGWOa7uKhUfYiBLY9Nl3evTmxE7s+J6JFxgQKJ2Ny+ofFqInEAnmbqKLh3rlVba8a7CcFFF7GR+0gZXDlutxWqg0DU7mYTZ2X1AJiFdAaBwIKXzGoM9wT8Ra1mw5+QNRjAqNkXA45cKsANzK3bC7j5Vkvn0Pg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rbZVe+Gb; arc=none smtp.client-ip=74.125.227.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rbZVe+Gb" Received: by mail-pj2-f42.google.com with SMTP id 98e67ed59e1d1-39b350c69b4so1163799a91.2 for ; Thu, 24 Sep 2026 00:11:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790233866; x=1790838666; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to:content-type; bh=ZuEmG6wBl2efC/945xSQ8zaEHszttX3U0I2BPYqa8Dk=; b=rbZVe+Gbn5WFoJNWmttbn9T/hrYcccuJLmz6b3bzQl6q2MqGIUboFWOOmhhTch1bzg YdebHXD2Lo8i4NywcmFbsCrZl92FnGBmPT0h2iB0adZsv3S4peYyAaH2ipwstoBOR9xm /YFPMuytnpUVsmCs0cJOG+iIOsWtcF4csBQhcGK4CorslU+0A7hh68DlIxalJgEks4L0 XJEhblVZbug6X33LZNCMGEstqXkZ3q0aw5zIFXacMZylwMpoosVSmvtBeG/LB7PgidN+ y7a84aLPMi/yfqx5QWIcxPSjvB3/RNrLzQY2bTYN3EAk5ibazlHpRFx1sUpnTj6uhU0W +yuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790233866; x=1790838666; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ZuEmG6wBl2efC/945xSQ8zaEHszttX3U0I2BPYqa8Dk=; b=p83JqbtUihqScPE5BhNuvfBbjyhkDGM3TqutrdAhgtV+618l6GXkQ5oXqL0AUVWgJL 5u3hrmz94YUp+ZWb4yupBmLnuj3n4bqhYPO68sjgTy/5QUWE8kNwjIhNmRgwhZnAy15y HrRD8b807QF2z7s6rY4D2xSHJIt8jOt3hUa+G29rlxEUeihF/TrqpQPQijgfdx/O4RED ZT0DNPYl3R3yfFBy9D7hHFVTV2PpPxIwLw+9QBayrSkgIBX7mkDhkOELZ4u6d7JpZzdv hR7Ou3WKBq4XTy8nMdOhkpdS5yRSrPGYJAORxU00A6b8zM0s8ZfNC84HKrk4MggTLdn3 j5rQ== X-Gm-Message-State: AFuF++kWTQ6FJQ2B06yDNsYBA+mRyVlQztjILkYstAnZWBodOaZqrCWN i/oIp40gCxYCpwm2kK+1bG/hYEf0lhpGdI48WDSY7wKu7p2T3fB5gWVN X-Gm-Gg: AYBFou31i/Bgsue7W2GTmv0JltG2BJH2b1OmGlgEu9eGAhFErzHsBoGLmPoEKYjzNA5 8sGpcBy7vW7p5A+D4oxk5Q5i2S61fuJFvvIEByhsHLJf51qi03T057EmUcKChrSK7S3jsiHtVN5 2q6fDBc5YuzYfHqxt/lSv49n9rlbS5D6QtGGxz3eKdq8lI8do8H6oAgHuKvfGCuo1cKySk2m55v fFEDH7PAFlGezNR2/aCf+za75uWrVP3nMwjsz6gxtZ1z+Kk2RrWLCHDPAnIoNiW/HvwAQ4iI+1H jyLxXub9HS3253wv/C5j7NEeHWNNzGr8h2Lwn/+J3DPnJmtPeblnv9n1MF/EYMdAHkJfV6Bt0IZ M6XGrXFAVkxG6lbk7NhYyQemzUE2+gA3Pt3Xou7xrwyjn4sgHIoGQyt8UPWYAbf3VNJ3ob+arSi VovYn2lkRrwMMr6jkqSRPARz3zzbz+j9X/QHNKMfWBt/xMspFgjUUO+wmRujDiSndVC12X6V+MS lVcOmKL05AgdYLXK4FJrWIBlSc= X-Received: by 2002:a17:90a:1090:b0:3a0:a515:c480 with SMTP id 98e67ed59e1d1-3a0a515c8cfmr85375a91.29.1790233865909; Thu, 24 Sep 2026 00:11:05 -0700 (PDT) Received: from [192.168.0.226] ([38.34.87.7]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3a09738f2absm3113496a91.14.2026.09.24.00.11.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 00:11:05 -0700 (PDT) Message-ID: <1eb267761bd627b63e5c78bdf76215c019aa3fa0.camel@gmail.com> Subject: Re: [PATCH 0/3] selftests/bpf: Fixes for out-of-tree builds From: Eduard Zingerman To: "Nico Pache (Red Hat)" , "Ricardo B." =?ISO-8859-1?Q?Marli=E8re?= "(SUSE)" , ihor.solodrai@linux.dev, nickolay.lysenko@gmail.com Cc: bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, Emil Tsalapatis , Jiri Olsa , Yonghong Song , Song Liu , Andrii Nakryiko , Shuah Khan , linux-kernel@vger.kernel.org, Kumar Kartikeya Dwivedi , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau Date: Thu, 24 Sep 2026 00:11:02 -0700 In-Reply-To: References: <20260728-selftests-bpf_oot-v1-0-05feb15d94db@marliere.net> <6f95ec90-194a-4304-9673-c7bb50065223@linux.dev> <9e055710-d607-4a4c-95c8-eb3a0b4aa1a1@linux.dev> <2a1875a99b173fec18d214419efbe876dcd95ad1.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.60.2 (3.60.2-2.fc44) Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Wed, 2026-09-23 at 14:06 -0600, Nico Pache (Red Hat) wrote: >=20 > On 9/21/26 3:42 PM, Eduard Zingerman wrote: > > On Mon, 2026-09-21 at 15:15 -0600, Nico Pache (Red Hat) wrote: > > >=20 > > > On 9/21/26 3:04 PM, Eduard Zingerman wrote: > > > > On Mon, 2026-09-21 at 14:40 -0600, Nico Pache (Red Hat) wrote: > > > >=20 > > > > ... > > > >=20 > > > > > Given your series was defferred, and there is a "rewrite" coming,= what would > > > > > be the best approach to working together (between us three) to ge= t these > > > > > fixes in that series too.=20 > > > >=20 > > > > The, "rewrite", as you call it, had landed today. > > >=20 > > > oh thats great news. I checked on Friday and didnt see it. Thanks for= the update :) > > >=20 > > > > So the series in question can be re-spun. > > > > Regarding your patch on top of it, it appears you can just post is = separately. > > > > However, I am inclined to be confrontational towards changes like t= his one. > > > > The purpose of the selftests makefile is to run selftests as approp= riate > > > > for current tip of the kernel tree using a very specific kernel con= figuration. > > > > Main users of this makefile are BPF developers and BPF CI. > > >=20 > > > Yeah we are trying to reincorporate BPF as part of our CI. It has bit= rotted in > > > the Fedora env, and our large amount of build variant is where things= are > > > starting to go wrong. We need to build selftests for multiple variant= s, and be > > > able to specify which variant we are building for. Hence the out-of-t= ree build > > > with specific vmlinux. > >=20 > > Why can't you build the kernel and the selftests in the same out of tre= e location? > > The change you are proposing is contained, but it's a death by thousand= cuts, > > the selftests makefile is quite a Frankenstein's monster already. >=20 > Due to incremental builds, and tool building in different env's Can you copy vmlinux to the output directory? > >=20 > > > Is there any other approach you'd suggest? I personally dont work on = BPF, but am > > > trying to cleanup/fix our selftests builds for Upstream/Fedora CI. > >=20 > > How many Fedora-specific kernel patches do you carry already? >=20 > So far its just the series Im replying to here, and the commit I appended= . Okay, I was under impression that distros bear a ton of custom patches and that adding another one adjusting random makefiles won't make a difference. If that is not the case, then I'm being unreasonable and the change is smal= l.