BPF List
 help / color / mirror / Atom feed
From: Yonghong Song <yonghong.song@linux.dev>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>, bpf@vger.kernel.org
Cc: daniel@iogearbox.net, andrii@kernel.org, martin.lau@kernel.org,
	kernel-team@fb.com
Subject: Re: [PATCH bpf-next] selftests/bpf: Remove intermediate test files.
Date: Wed, 21 Feb 2024 08:19:28 -0800	[thread overview]
Message-ID: <1ef40b6b-a1be-4469-932f-51b3a0b68cba@linux.dev> (raw)
In-Reply-To: <20240220231102.49090-1-alexei.starovoitov@gmail.com>


On 2/20/24 3:11 PM, Alexei Starovoitov wrote:
> From: Alexei Starovoitov <ast@kernel.org>
>
> The test of linking process creates several intermediate files.
> Remove them once the build is over.
> This reduces the number of files in selftests/bpf/ directory
> from ~4400 to ~2600.
>
> Signed-off-by: Alexei Starovoitov <ast@kernel.org>

It looks like some light skeleton *llinked*.o files left.
   [~/work/bpf-next/tools/testing/selftests/bpf (master)]$ ls *linked1*
   atomics.bpf.llinked1.o             fexit_sleep.bpf.llinked1.o              map_ptr_kern.bpf.llinked1.o       test_ringbuf_map_key.bpf.llinked1.o
   core_kern.bpf.llinked1.o           fexit_test.bpf.llinked1.o               test_ksyms_module.bpf.llinked1.o  test_static_linked1.bpf.o
   core_kern_overflow.bpf.llinked1.o  kfunc_call_test.bpf.llinked1.o          test_ksyms_weak.bpf.llinked1.o    trace_printk.bpf.llinked1.o
   fentry_test.bpf.llinked1.o         kfunc_call_test_subprog.bpf.llinked1.o  test_ringbuf.bpf.llinked1.o       trace_vprintk.bpf.llinked1.o
   [~/work/bpf-next/tools/testing/selftests/bpf (master)]$

All of them from:
   LSKELS := fentry_test.c fexit_test.c fexit_sleep.c atomics.c            \
         trace_printk.c trace_vprintk.c map_ptr_kern.c                   \
         core_kern.c core_kern_overflow.c test_ringbuf.c                 \
         test_ringbuf_map_key.c
   LSKELS_EXTRA := test_ksyms_module.c test_ksyms_weak.c kfunc_call_test.c \
         kfunc_call_test_subprog.c

Considering we only have limited light skeletons, so it should not be a problem. So

Acked-by: Yonghong Song <yonghong.song@linux.dev>


  reply	other threads:[~2024-02-21 16:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-20 23:11 [PATCH bpf-next] selftests/bpf: Remove intermediate test files Alexei Starovoitov
2024-02-21 16:19 ` Yonghong Song [this message]
2024-02-21 16:30 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1ef40b6b-a1be-4469-932f-51b3a0b68cba@linux.dev \
    --to=yonghong.song@linux.dev \
    --cc=alexei.starovoitov@gmail.com \
    --cc=andrii@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=kernel-team@fb.com \
    --cc=martin.lau@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox