From: Eduard Zingerman <eddyz87@gmail.com>
To: Emil Tsalapatis <emil@etsalapatis.com>, bpf@vger.kernel.org
Cc: ast@kernel.org, daniel@iogearbox.net, john.fastabend@gmail.com,
memxor@gmail.com, andrii@kernel.org, yonghong.song@linux.dev
Subject: Re: [PATCH v2 1/4] selftests/bpf: explicitly account for globals in verifier_arena_large
Date: Fri, 21 Nov 2025 17:44:37 -0800 [thread overview]
Message-ID: <1f18cdddbbf1d1273ff045d769c54fbc4dfe4a6a.camel@gmail.com> (raw)
In-Reply-To: <20251118030058.162967-2-emil@etsalapatis.com>
On Mon, 2025-11-17 at 22:00 -0500, Emil Tsalapatis wrote:
> The big_alloc1 test in verifier_arena_large assumes that the arena base
> and the first page allocated by bpf_arena_alloc_pages are identical.
> This is not the case, because the first page in the arena is populated
> by global arena data. The test still passes because the code makes the
> tacit assumption that the first page is on offset PAGE_SIZE instead of
> 0.
>
> Make this distinction explicit in the code, and adjust the page offsets
> requested during the test to count from the beginning of the arena
> instead of using the address of the first allocated page.
>
> Signed-off-by: Emil Tsalapatis <emil@etsalapatis.com>
> ---
Seems correct.
Reviewed-by: Eduard Zingerman <eddyz87@gmail.com>
[...]
next prev parent reply other threads:[~2025-11-22 1:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-18 3:00 [PATCH v2 0/4] libbpf: move arena variables out of the zero page Emil Tsalapatis
2025-11-18 3:00 ` [PATCH v2 1/4] selftests/bpf: explicitly account for globals in verifier_arena_large Emil Tsalapatis
2025-11-22 1:44 ` Eduard Zingerman [this message]
2025-11-18 3:00 ` [PATCH v2 2/4] libbpf: add stub for offset-related skeleton padding Emil Tsalapatis
2025-11-18 3:00 ` [PATCH v2 3/4] libbpf: offset global arena data into the arena if possible Emil Tsalapatis
2025-11-22 3:17 ` Eduard Zingerman
2025-12-01 18:34 ` Emil Tsalapatis
2025-12-01 22:35 ` Eduard Zingerman
2025-12-03 16:07 ` Emil Tsalapatis
2025-11-25 22:11 ` Andrii Nakryiko
2025-12-01 20:41 ` Emil Tsalapatis
2025-12-01 22:45 ` Andrii Nakryiko
2025-12-03 16:13 ` Emil Tsalapatis
2025-11-18 3:00 ` [PATCH v2 4/4] selftests/bpf: add tests for the arena offset of globals Emil Tsalapatis
-- strict thread matches above, loose matches on Subject: below --
2025-12-03 16:26 [PATCH v2 0/4] libbpf: move arena variables out of the zero Emil Tsalapatis
2025-12-03 16:26 ` [PATCH v2 1/4] selftests/bpf: explicitly account for globals in verifier_arena_large Emil Tsalapatis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f18cdddbbf1d1273ff045d769c54fbc4dfe4a6a.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=emil@etsalapatis.com \
--cc=john.fastabend@gmail.com \
--cc=memxor@gmail.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox