Re: [PATCH bpf-next] libbpf: fix error handling in btf__distill_base()

[Alan Maguire <alan.maguire@oracle.com>]

On 29/06/2024 11:00, Alan Maguire wrote:
> Coverity points out that after calling btf__new_empty_split()
> the wrong value is checked for error.
> 
> Reported-by: Andrii Nakryiko <andrii@kernel.org>
> Signed-off-by: Alan Maguire <alan.maguire@oracle.com>

apologies, forgot

Fixes: 58e185a0dc35 ("libbpf: Add btf__distill_base() creating split BTF
with distilled base BTF")
> ---
>  tools/lib/bpf/btf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/lib/bpf/btf.c b/tools/lib/bpf/btf.c
> index cd5dd6619214..32c00db3b91b 100644
> --- a/tools/lib/bpf/btf.c
> +++ b/tools/lib/bpf/btf.c
> @@ -5431,7 +5431,7 @@ int btf__distill_base(const struct btf *src_btf, struct btf **new_base_btf,
>  	 * BTF available.
>  	 */
>  	new_split = btf__new_empty_split(new_base);
> -	if (!new_split_btf) {
> +	if (!new_split) {
>  		err = -errno;
>  		goto done;
>  	}