public inbox for bpf@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
	Andrii Nakryiko <andriin@fb.com>, Alexei Starovoitov <ast@fb.com>,
	dwarves@vger.kernel.org, bpf@vger.kernel.org, kernel-team@fb.com,
	Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
	Wang Nan <wangnan0@huawei.com>
Subject: Re: [PATCH pahole 2/2] btf_encoder: run BTF deduplication before writing out to ELF
Date: Mon, 18 Feb 2019 16:55:15 -0300	[thread overview]
Message-ID: <20190218195515.GT31177@kernel.org> (raw)
In-Reply-To: <CAEf4BzYCD91JaoJyTRi2i3BS69=TkJVh34uc8++Wwd7B5nExLA@mail.gmail.com>

Em Mon, Feb 18, 2019 at 11:38:41AM -0800, Andrii Nakryiko escreveu:
> On Mon, Feb 18, 2019 at 6:29 AM Arnaldo Carvalho de Melo wrote:
> > Thanks for all the cool work!
 
> My pleasure, it was fun! :)

So, next step, tag a pahole release and announce it, but I wonder about
the libbpf linking, wouldn't be better, for now, to make it link
statically with libbpf?

I ask this because libbpf isn't yet generally available, so perhaps we
should have some logic to detect if it is available and link against it
or if not, use the module stuff we have now and link it statically,
wdyt?

Hopefully we get the problems noticed via btfdiff before that.

- Arnaldo

  reply	other threads:[~2019-02-18 19:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-17  8:20 [PATCH pahole 0/2] Add support for BTF deduplication Andrii Nakryiko
2019-02-17  8:20 ` [PATCH pahole 1/2] libbpf: pull latest libbpf and build libbpf as shared lib Andrii Nakryiko
2019-02-18 12:48   ` Arnaldo Carvalho de Melo
2019-02-17  8:20 ` [PATCH pahole 2/2] btf_encoder: run BTF deduplication before writing out to ELF Andrii Nakryiko
     [not found]   ` <20190218142900.GR31177@kernel.org>
2019-02-18 19:38     ` Andrii Nakryiko
2019-02-18 19:55       ` Arnaldo Carvalho de Melo [this message]
2019-02-19  2:44         ` Andrii Nakryiko
2019-02-19  2:46           ` Alexei Starovoitov
2019-02-19 13:56       ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190218195515.GT31177@kernel.org \
    --to=acme@kernel.org \
    --cc=andrii.nakryiko@gmail.com \
    --cc=andriin@fb.com \
    --cc=arnaldo.melo@gmail.com \
    --cc=ast@fb.com \
    --cc=bpf@vger.kernel.org \
    --cc=dwarves@vger.kernel.org \
    --cc=jolsa@kernel.org \
    --cc=kernel-team@fb.com \
    --cc=namhyung@kernel.org \
    --cc=wangnan0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox