From: Jiri Olsa <jolsa@redhat.com>
To: Yonghong Song <yhs@fb.com>
Cc: Michal Rostecki <mrostecki@opensuse.org>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrey Ignatov <rdna@fb.com>,
Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
Song Liu <songliubraving@fb.com>, bpf <bpf@vger.kernel.org>,
Brenden Blanco <bblanco@gmail.com>
Subject: Re: libbpf packaging
Date: Wed, 27 Mar 2019 08:20:05 +0100 [thread overview]
Message-ID: <20190327072005.GA24156@krava> (raw)
In-Reply-To: <0715b98f-6017-7b9d-61b5-ca08ddd539e5@fb.com>
On Wed, Mar 27, 2019 at 05:30:44AM +0000, Yonghong Song wrote:
> Jiri,
>
> >>>>>> 2) There's already bcc-devel's libbpf library packaged:
> >>>>>>
> >>>>>> $ rpm -qf /usr/lib64/libbpf.so
> >>>>>> bcc-devel-0.8.0-1.fc28.x86_64
> >>>>>>
> >>>>>> so there's a conflict.. any chance we could rename libbpf to
> >>>>>> something else like:
> >>>>>>
> >>>>>> libbpf2.so
> >>>>>> libbpfobject.so
> >>>>>> libbpfbest.so
> >>>>>> ...?
> >>>>>
> >>>>> I don't think we should rename the official libbpf package, this will
> >>>>> just create plain confusion and will make it much harder for potential
> >>>>> users to adapt in the long-term since we aim for /everyone/ to consume
> >>>>> official libbpf library instead of hacking their own.
> >>>>>
> >>>>> I think bcc folks are migrating to official libbpf as well, at least
> >>>>> that was my impression. Imho, this would need fixing on bcc side then.
> >>>>
> >>>> bcc migrated to libbpf some time ago.
> >>>
> >>> And the libbpf.so file which is installed with bcc is "our" libbpf. bcc
> >>> simply uses libbpf (from the auto-synced standalone repo[0]) as a
> >>> submodule[1]. To package libbpf and bcc properly in Linux distros we
> >>> need a possibility to use bcc with shared libbpf library - which
> >>> probably can be achiveved by small change in bcc's CMakeLists.txt.
> >>
> >> I think we should rename bcc libbpf.so to a different name (maybe
> >> libbcc_bpf.so) to avoid confusions between bcc libbpf and libbpf repo.
> >> The bcc libbpf.so is different from libbpf repo it contains some wrappers...
> >
> > that'd be great first step.. then we could add libbpf
> > package and make bcc depend on it as suggested by Michal
> >
> >>
> >> I will propose to iovisor/bcc mailing list.
> >
> > please keep me in cc for that
>
> Do not know your github name, so not able to cc you on the bcc pull
> request which changes library from libbpf.{a,so} to libbcc_bpf.{a,so}.
> The below is the link:
> https://github.com/iovisor/bcc/pull/2290
it's olsajiri, that should do it, thanks
jirka
prev parent reply other threads:[~2019-03-27 7:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 12:21 libbpf packaging Jiri Olsa
2019-03-25 12:52 ` Daniel Borkmann
2019-03-25 16:03 ` Alexei Starovoitov
2019-03-25 17:19 ` Jiri Olsa
2019-03-25 17:21 ` Michal Rostecki
2019-03-25 19:34 ` Yonghong Song
2019-03-25 20:20 ` Jiri Olsa
2019-03-27 5:30 ` Yonghong Song
2019-03-27 7:20 ` Jiri Olsa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190327072005.GA24156@krava \
--to=jolsa@redhat.com \
--cc=alexei.starovoitov@gmail.com \
--cc=arnaldo.melo@gmail.com \
--cc=bblanco@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=mrostecki@opensuse.org \
--cc=rdna@fb.com \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).