From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8CB8C43381 for ; Wed, 27 Mar 2019 07:20:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B7C022075E for ; Wed, 27 Mar 2019 07:20:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731467AbfC0HUI (ORCPT ); Wed, 27 Mar 2019 03:20:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54394 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725772AbfC0HUI (ORCPT ); Wed, 27 Mar 2019 03:20:08 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D50D0305390F; Wed, 27 Mar 2019 07:20:07 +0000 (UTC) Received: from krava (unknown [10.43.17.124]) by smtp.corp.redhat.com (Postfix) with SMTP id CE9CF60C96; Wed, 27 Mar 2019 07:20:05 +0000 (UTC) Date: Wed, 27 Mar 2019 08:20:05 +0100 From: Jiri Olsa To: Yonghong Song Cc: Michal Rostecki , Alexei Starovoitov , Daniel Borkmann , Andrey Ignatov , Arnaldo Carvalho de Melo , Song Liu , bpf , Brenden Blanco Subject: Re: libbpf packaging Message-ID: <20190327072005.GA24156@krava> References: <20190325122134.GA14042@krava> <854218ad-ce5c-cd00-7772-97bd9bc379a1@iogearbox.net> <20190325172115.i35nfrelzkwqgyoy@workstation> <20190325202009.GA14511@krava> <0715b98f-6017-7b9d-61b5-ca08ddd539e5@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0715b98f-6017-7b9d-61b5-ca08ddd539e5@fb.com> User-Agent: Mutt/1.11.3 (2019-02-01) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Wed, 27 Mar 2019 07:20:08 +0000 (UTC) Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Wed, Mar 27, 2019 at 05:30:44AM +0000, Yonghong Song wrote: > Jiri, > > >>>>>> 2) There's already bcc-devel's libbpf library packaged: > >>>>>> > >>>>>> $ rpm -qf /usr/lib64/libbpf.so > >>>>>> bcc-devel-0.8.0-1.fc28.x86_64 > >>>>>> > >>>>>> so there's a conflict.. any chance we could rename libbpf to > >>>>>> something else like: > >>>>>> > >>>>>> libbpf2.so > >>>>>> libbpfobject.so > >>>>>> libbpfbest.so > >>>>>> ...? > >>>>> > >>>>> I don't think we should rename the official libbpf package, this will > >>>>> just create plain confusion and will make it much harder for potential > >>>>> users to adapt in the long-term since we aim for /everyone/ to consume > >>>>> official libbpf library instead of hacking their own. > >>>>> > >>>>> I think bcc folks are migrating to official libbpf as well, at least > >>>>> that was my impression. Imho, this would need fixing on bcc side then. > >>>> > >>>> bcc migrated to libbpf some time ago. > >>> > >>> And the libbpf.so file which is installed with bcc is "our" libbpf. bcc > >>> simply uses libbpf (from the auto-synced standalone repo[0]) as a > >>> submodule[1]. To package libbpf and bcc properly in Linux distros we > >>> need a possibility to use bcc with shared libbpf library - which > >>> probably can be achiveved by small change in bcc's CMakeLists.txt. > >> > >> I think we should rename bcc libbpf.so to a different name (maybe > >> libbcc_bpf.so) to avoid confusions between bcc libbpf and libbpf repo. > >> The bcc libbpf.so is different from libbpf repo it contains some wrappers... > > > > that'd be great first step.. then we could add libbpf > > package and make bcc depend on it as suggested by Michal > > > >> > >> I will propose to iovisor/bcc mailing list. > > > > please keep me in cc for that > > Do not know your github name, so not able to cc you on the bcc pull > request which changes library from libbpf.{a,so} to libbcc_bpf.{a,so}. > The below is the link: > https://github.com/iovisor/bcc/pull/2290 it's olsajiri, that should do it, thanks jirka