From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Saeed Mahameed <saeedm@mellanox.com>
Cc: "toke@redhat.com" <toke@redhat.com>,
"daniel@iogearbox.net" <daniel@iogearbox.net>,
"ast@kernel.org" <ast@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"bjorn.topel@gmail.com" <bjorn.topel@gmail.com>,
"magnus.karlsson@intel.com" <magnus.karlsson@intel.com>,
"bjorn.topel@intel.com" <bjorn.topel@intel.com>,
"brouer@redhat.com" <brouer@redhat.com>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>
Subject: Re: [PATCH bpf-next v2 1/2] net: xdp: refactor XDP_QUERY_PROG{,_HW} to netdev
Date: Sat, 1 Jun 2019 12:57:17 -0700 [thread overview]
Message-ID: <20190601125717.28982f35@cakuba.netronome.com> (raw)
In-Reply-To: <b0a9c3b198bdefd145c34e52aa89d33aa502aaf5.camel@mellanox.com>
On Fri, 31 May 2019 19:18:17 +0000, Saeed Mahameed wrote:
> > + if (!bpf_op || flags & XDP_FLAGS_SKB_MODE)
> > + mode = XDP_FLAGS_SKB_MODE;
> > +
> > + curr_mode = dev_xdp_current_mode(dev);
> > +
> > + if (!offload && curr_mode && (mode ^ curr_mode) &
> > + (XDP_FLAGS_DRV_MODE | XDP_FLAGS_SKB_MODE)) {
>
> if i am reading this correctly this is equivalent to :
>
> if (!offload && (curre_mode != mode))
> offlad is false then curr_mode and mode must be DRV or GENERIC ..
Naw, if curr_mode is not set, i.e. nothing installed now, we don't care
about the diff.
> better if you keep bitwise operations for actual bitmasks, mode and
> curr_mode are not bitmask, they can hold one value each .. according to
> your logic..
Well, they hold one bit each, whether one bit is a bitmap perhaps is
disputable? :)
I think the logic is fine.
What happened to my request to move the change in behaviour for
disabling to a separate patch, tho, Bjorn? :)
next prev parent reply other threads:[~2019-06-01 19:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-31 9:42 [PATCH bpf-next v2 0/2] net: xdp: refactor the XDP_QUERY_PROG and XDP_QUERY_PROG_HW code Björn Töpel
2019-05-31 9:42 ` [PATCH bpf-next v2 1/2] net: xdp: refactor XDP_QUERY_PROG{,_HW} to netdev Björn Töpel
2019-05-31 19:18 ` Saeed Mahameed
2019-06-01 19:42 ` Jakub Kicinski
2019-06-03 9:04 ` Björn Töpel
2019-06-03 21:20 ` Saeed Mahameed
2019-06-04 5:18 ` Björn Töpel
2019-06-04 10:17 ` Jesper Dangaard Brouer
2019-06-01 19:57 ` Jakub Kicinski [this message]
2019-06-03 9:04 ` Björn Töpel
2019-06-03 17:03 ` Jakub Kicinski
2019-06-04 5:16 ` Björn Töpel
2019-06-01 9:50 ` kbuild test robot
2019-06-01 18:12 ` Jonathan Lemon
2019-06-03 8:39 ` Björn Töpel
2019-06-03 14:58 ` Jonathan Lemon
2019-06-03 23:11 ` Daniel Borkmann
2019-06-04 5:37 ` Björn Töpel
2019-06-01 20:02 ` Jakub Kicinski
2019-06-03 9:07 ` Björn Töpel
2019-06-03 10:56 ` Toke Høiland-Jørgensen
2019-05-31 9:42 ` [PATCH bpf-next v2 2/2] net: xdp: remove XDP_QUERY_PROG{,_HW} Björn Töpel
2019-05-31 9:45 ` [PATCH bpf-next v2 0/2] net: xdp: refactor the XDP_QUERY_PROG and XDP_QUERY_PROG_HW code Björn Töpel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190601125717.28982f35@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=ast@kernel.org \
--cc=bjorn.topel@gmail.com \
--cc=bjorn.topel@intel.com \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox