From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4482C7618B for ; Thu, 25 Jul 2019 15:33:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ADABE229F3 for ; Thu, 25 Jul 2019 15:33:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="YNvSAO1j" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388850AbfGYPdq (ORCPT ); Thu, 25 Jul 2019 11:33:46 -0400 Received: from mail-pg1-f201.google.com ([209.85.215.201]:55892 "EHLO mail-pg1-f201.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388082AbfGYPdq (ORCPT ); Thu, 25 Jul 2019 11:33:46 -0400 Received: by mail-pg1-f201.google.com with SMTP id z14so23895532pgr.22 for ; Thu, 25 Jul 2019 08:33:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=JXZL8O7+Ny9KufAmHovMTntdK68YTy/GrGGZHk3basc=; b=YNvSAO1jnS595Js7/guXuvD93UvBbbdd/JC8m0CgIueiB7TvYFUefgINGwGu2q8pwg JDJd8TbjAwjmRyc/vShO+aY29yTiDAZz11rA8Z5mhHR6zFSEHtCcjWdVj1l/rtb6AUex IxCO6Pzw9ZSWwKC5iTcegGzp8YhjkTXaD4p5eC2ECIirLXtlJmqWzLm2HdZdRd15U7B1 FJ3N68b5599jkrnLryJTc8VVjnefSkRF1kZNRYW00ptFUKqq8inxDlnebBg/8Gefkc+g A/POf5qme7iAPy0Whu+vIkALEaS0+/t74dWFuYMPtuxzoFTUmoclHyg4DZpkWsePe6vO 482Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=JXZL8O7+Ny9KufAmHovMTntdK68YTy/GrGGZHk3basc=; b=C0WWkd1qX3b4zba8oQHmBkf0Zw4Vhy7zDGlWCd/K0enWDcqYTQTlJydt8muNhTcf4u hYIAgrc3HW0gnZBfPNTplKGHQt9Uusl3OG/TpV8+IATgWsrp5/C0q8LWorBSrBuKYqbi R+IfbaRyQ6ZrQsSyKQqeF1NFMWiQz7n5mm8f8FvVJqYbFDUwsEQDXyCCw91vzP8SFGTC IFzxK6mu+IZj0yUo32e404M7OJkL/k8EUoBVgCMiEeCbmYUKxkCnxO0tB6BtrF4tQ4jP ZyluxJYHVM9jX0FQG9WawkOmBnhrfk5DAROav1qWUCaPM3sn2fz3FCBzzb20Dde+xEPJ Ky+Q== X-Gm-Message-State: APjAAAVTTvovnMD2swYB72peRaEhIEgwQp5Ssivg700Aef4BC62EdlDF ++yasltBT4CsnO46poOlSZ2CH6k= X-Google-Smtp-Source: APXvYqwVUu5VVXovpC4YNjW6B/73K1rdfrJa4t4iMdK0HFrEz7n9Ekd0UgnlKWZG7emkqKgYUXgIAfY= X-Received: by 2002:a63:6154:: with SMTP id v81mr53597390pgb.296.1564068824620; Thu, 25 Jul 2019 08:33:44 -0700 (PDT) Date: Thu, 25 Jul 2019 08:33:35 -0700 Message-Id: <20190725153342.3571-1-sdf@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.22.0.657.g960e92d24f-goog Subject: [PATCH bpf-next v2 0/7] bpf/flow_dissector: support input flags From: Stanislav Fomichev To: netdev@vger.kernel.org, bpf@vger.kernel.org Cc: davem@davemloft.net, ast@kernel.org, daniel@iogearbox.net, Stanislav Fomichev , Song Liu , Willem de Bruijn , Petar Penkov Content-Type: text/plain; charset="UTF-8" Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org C flow dissector supports input flags that tell it to customize parsing by either stopping early or trying to parse as deep as possible. BPF flow dissector always parses as deep as possible which is sub-optimal. Pass input flags to the BPF flow dissector as well so it can make the same decisions. Series outline: * remove unused FLOW_DISSECTOR_F_STOP_AT_L3 flag * export FLOW_DISSECTOR_F_XXX flags as uapi and pass them to BPF flow dissector * add documentation for the export flags * support input flags in BPF_PROG_TEST_RUN via ctx_{in,out} * sync uapi to tools * support FLOW_DISSECTOR_F_PARSE_1ST_FRAG in selftest * support FLOW_DISSECTOR_F_STOP_AT_FLOW_LABEL in kernel and selftest * support FLOW_DISSECTOR_F_STOP_AT_ENCAP in selftest Pros: * makes BPF flow dissector faster by avoiding burning extra cycles * existing BPF progs continue to work by ignoring the flags and always parsing as deep as possible Cons: * new UAPI which we need to support (OTOH, if we need to deprecate some flags, we can just stop setting them upon calling BPF programs) Some numbers (with .repeat = 4000000 in test_flow_dissector): test_flow_dissector:PASS:ipv4-frag 35 nsec test_flow_dissector:PASS:ipv4-frag 35 nsec test_flow_dissector:PASS:ipv4-no-frag 32 nsec test_flow_dissector:PASS:ipv4-no-frag 32 nsec test_flow_dissector:PASS:ipv6-frag 39 nsec test_flow_dissector:PASS:ipv6-frag 39 nsec test_flow_dissector:PASS:ipv6-no-frag 36 nsec test_flow_dissector:PASS:ipv6-no-frag 36 nsec test_flow_dissector:PASS:ipv6-flow-label 36 nsec test_flow_dissector:PASS:ipv6-flow-label 36 nsec test_flow_dissector:PASS:ipv6-no-flow-label 33 nsec test_flow_dissector:PASS:ipv6-no-flow-label 33 nsec test_flow_dissector:PASS:ipip-encap 38 nsec test_flow_dissector:PASS:ipip-encap 38 nsec test_flow_dissector:PASS:ipip-no-encap 32 nsec test_flow_dissector:PASS:ipip-no-encap 32 nsec The improvement is around 10%, but it's in a tight cache-hot BPF_PROG_TEST_RUN loop. Cc: Song Liu Cc: Willem de Bruijn Cc: Petar Penkov Stanislav Fomichev (7): bpf/flow_dissector: pass input flags to BPF flow dissector program bpf/flow_dissector: document flags bpf/flow_dissector: support flags in BPF_PROG_TEST_RUN tools/bpf: sync bpf_flow_keys flags selftests/bpf: support FLOW_DISSECTOR_F_PARSE_1ST_FRAG bpf/flow_dissector: support ipv6 flow_label and FLOW_DISSECTOR_F_STOP_AT_FLOW_LABEL selftests/bpf: support FLOW_DISSECTOR_F_STOP_AT_ENCAP Documentation/bpf/prog_flow_dissector.rst | 18 ++ include/linux/skbuff.h | 2 +- include/net/flow_dissector.h | 4 - include/uapi/linux/bpf.h | 6 + net/bpf/test_run.c | 39 ++- net/core/flow_dissector.c | 14 +- tools/include/uapi/linux/bpf.h | 6 + .../selftests/bpf/prog_tests/flow_dissector.c | 242 +++++++++++++++++- tools/testing/selftests/bpf/progs/bpf_flow.c | 46 +++- 9 files changed, 359 insertions(+), 18 deletions(-) -- 2.22.0.657.g960e92d24f-goog