From: Quentin Monnet <quentin.monnet@netronome.com>
To: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org,
oss-drivers@netronome.com,
Quentin Monnet <quentin.monnet@netronome.com>
Subject: [PATCH bpf 0/6] tools: bpftool: fix printf()-like functions
Date: Thu, 15 Aug 2019 15:32:14 +0100 [thread overview]
Message-ID: <20190815143220.4199-1-quentin.monnet@netronome.com> (raw)
Hi,
Because the "__printf()" attributes were used only where the functions are
implemented, and not in header files, the checks have not been enforced on
all the calls to printf()-like functions, and a number of errors slipped in
bpftool over time.
This set cleans up such errors, and then moves the "__printf()" attributes
to header files, so that the checks are performed at all locations.
Quentin Monnet (6):
tools: bpftool: fix arguments for p_err() in do_event_pipe()
tools: bpftool: fix format strings and arguments for jsonw_printf()
tools: bpftool: fix argument for p_err() in BTF do_dump()
tools: bpftool: fix format string for p_err() in
query_flow_dissector()
tools: bpftool: fix format string for p_err() in
detect_common_prefix()
tools: bpftool: move "__printf()" attributes to header file
tools/bpf/bpftool/btf.c | 2 +-
tools/bpf/bpftool/btf_dumper.c | 8 ++++----
tools/bpf/bpftool/common.c | 4 ++--
tools/bpf/bpftool/json_writer.c | 6 ++----
tools/bpf/bpftool/json_writer.h | 6 ++++--
tools/bpf/bpftool/main.c | 2 +-
tools/bpf/bpftool/main.h | 4 ++--
tools/bpf/bpftool/map_perf_ring.c | 4 ++--
tools/bpf/bpftool/net.c | 2 +-
tools/include/linux/compiler-gcc.h | 2 ++
10 files changed, 21 insertions(+), 19 deletions(-)
--
2.17.1
next reply other threads:[~2019-08-15 14:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 14:32 Quentin Monnet [this message]
2019-08-15 14:32 ` [PATCH bpf 1/6] tools: bpftool: fix arguments for p_err() in do_event_pipe() Quentin Monnet
2019-08-15 14:32 ` [PATCH bpf 2/6] tools: bpftool: fix format strings and arguments for jsonw_printf() Quentin Monnet
2019-08-15 14:32 ` [PATCH bpf 3/6] tools: bpftool: fix argument for p_err() in BTF do_dump() Quentin Monnet
2019-08-15 14:32 ` [PATCH bpf 4/6] tools: bpftool: fix format string for p_err() in query_flow_dissector() Quentin Monnet
2019-08-15 14:32 ` [PATCH bpf 5/6] tools: bpftool: fix format string for p_err() in detect_common_prefix() Quentin Monnet
2019-08-15 14:32 ` [PATCH bpf 6/6] tools: bpftool: move "__printf()" attributes to header file Quentin Monnet
2019-08-16 5:08 ` [PATCH bpf 0/6] tools: bpftool: fix printf()-like functions Alexei Starovoitov
2019-08-16 16:41 ` Quentin Monnet
2019-08-16 17:11 ` Alexei Starovoitov
2019-08-16 17:18 ` Quentin Monnet
2019-08-16 17:51 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190815143220.4199-1-quentin.monnet@netronome.com \
--to=quentin.monnet@netronome.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox