BPF List
 help / color / mirror / Atom feed
From: Peter Wu <peter@lekensteyn.nl>
To: Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org
Subject: [PATCH v2 3/4] bpf: clarify when bpf_trace_printk discards lines
Date: Wed, 21 Aug 2019 00:08:59 +0100	[thread overview]
Message-ID: <20190820230900.23445-4-peter@lekensteyn.nl> (raw)
In-Reply-To: <20190820230900.23445-1-peter@lekensteyn.nl>

I opened /sys/kernel/tracing/trace once and kept reading from it.
bpf_trace_printk somehow did not seem to work, no entries were appended
to that trace file. It turns out that tracing is disabled when that file
is open. Save the next person some time and document this.

The trace file is described in Documentation/trace/ftrace.rst, however
the implication "tracing is disabled" did not immediate translate to
"bpf_trace_printk silently discards entries".

Signed-off-by: Peter Wu <peter@lekensteyn.nl>
---
 include/uapi/linux/bpf.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h
index 9ca333c3ce91..e4236e357ed9 100644
--- a/include/uapi/linux/bpf.h
+++ b/include/uapi/linux/bpf.h
@@ -575,6 +575,8 @@ union bpf_attr {
  * 		limited to five).
  *
  * 		Each time the helper is called, it appends a line to the trace.
+ * 		Lines are discarded while *\/sys/kernel/debug/tracing/trace* is
+ * 		open, use *\/sys/kernel/debug/tracing/trace_pipe* to avoid this.
  * 		The format of the trace is customizable, and the exact output
  * 		one will get depends on the options set in
  * 		*\/sys/kernel/debug/tracing/trace_options* (see also the
-- 
2.22.0


  parent reply	other threads:[~2019-08-20 23:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-20 23:08 [PATCH v2 0/4] BPF-related documentation fixes Peter Wu
2019-08-20 23:08 ` [PATCH v2 1/4] bpf: clarify description for CONFIG_BPF_EVENTS Peter Wu
2019-08-20 23:08 ` [PATCH v2 2/4] bpf: fix 'struct pt_reg' typo in documentation Peter Wu
2019-08-21 10:28   ` Quentin Monnet
2019-08-20 23:08 ` Peter Wu [this message]
2019-08-20 23:22   ` [PATCH v2 3/4] bpf: clarify when bpf_trace_printk discards lines Alexei Starovoitov
2019-08-21  0:04     ` Peter Wu
2019-08-21 17:23       ` Alexei Starovoitov
2019-08-20 23:09 ` [PATCH v2 4/4] bpf: sync bpf.h to tools/ Peter Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190820230900.23445-4-peter@lekensteyn.nl \
    --to=peter@lekensteyn.nl \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox