From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F641C3A5A6 for ; Wed, 28 Aug 2019 17:37:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 77E242077B for ; Wed, 28 Aug 2019 17:37:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="oFW8k5sh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726623AbfH1RhV (ORCPT ); Wed, 28 Aug 2019 13:37:21 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:40081 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726980AbfH1Rg1 (ORCPT ); Wed, 28 Aug 2019 13:36:27 -0400 Received: by mail-pf1-f193.google.com with SMTP id w16so242247pfn.7 for ; Wed, 28 Aug 2019 10:36:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=m0Ol9KiCJuTthVJpNdqXavAOI9ULv3o3m1zh5s9b1As=; b=oFW8k5shx9dzTZCg4oYfKxxrESLsvpAIA5QCO3DOe5JfSNX5ICxHFKvHATbc9VgD3w 5+rVewSkK5+kiL+7lS0d7oAaUMKOuRqjYZaH4CxrLhIbqdMKdMJyL9TmnRR+lSFDhS+9 H/J3m1QfdE0eP7mou/vg7EAYza9c0CwIYY860= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=m0Ol9KiCJuTthVJpNdqXavAOI9ULv3o3m1zh5s9b1As=; b=X8URLB95bolFiCahQYd5RMwVhjS7540PMqrsOsdq1F/HDrLs8uzrpJY5/MgCT8eex5 CCeJgBgTA9Pm33QosmVku0VIaHrVc82OiOHa6gObm6Q1MZG/papWW9Ty2Ep2MZ5cHkIN caJDgzLcfbSf1lGLTQhxaLx0IXaSCVzvvwWCY/+yQFNdAVmtJvNYVdMrGNJR1rlXPLOO a0UCTYYn76itJ8bLZDmu7ouAczdSpgbeC89T8M6Ray6V4WqsGwNde8owGvvfInbLu9gU 95cD+4wmwinOzpc0Guf8zm7bK05vG8MNlY2j4zlU+QdtmdmHAg2PtTTKQyfddrTqJ8dz 3U1w== X-Gm-Message-State: APjAAAV1KM0s+Rb5eoHDuMlLrMnrM4MdIgAx9NNt6vCk9c+p5Wqbh6qq B/b4fEzzCE6YUTnpkAx47e2wkw== X-Google-Smtp-Source: APXvYqyH/WYT3nu0TOtBHExVMlqdFHVZ7R0fY91sEAf7okZikcnLyqTOEJjyRHLyXhLgGQXRNGz22Q== X-Received: by 2002:a63:f13:: with SMTP id e19mr4496092pgl.132.1567013786692; Wed, 28 Aug 2019 10:36:26 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id d11sm4397723pfh.59.2019.08.28.10.36.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Aug 2019 10:36:25 -0700 (PDT) Date: Sun, 25 Aug 2019 14:59:37 -0700 From: Kees Cook To: David Abdurachmanov Cc: Paul Walmsley , Palmer Dabbelt , Albert Ou , Oleg Nesterov , Andy Lutomirski , Will Drewry , Shuah Khan , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , David Abdurachmanov , Thomas Gleixner , Allison Randal , Alexios Zavras , Anup Patel , Vincent Chen , Alan Kao , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, me@carlosedp.com Subject: Re: [PATCH v2] riscv: add support for SECCOMP and SECCOMP_FILTER Message-ID: <201908251451.73C6812E8@keescook> References: <20190822205533.4877-1-david.abdurachmanov@sifive.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190822205533.4877-1-david.abdurachmanov@sifive.com> Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Thu, Aug 22, 2019 at 01:55:22PM -0700, David Abdurachmanov wrote: > This patch was extensively tested on Fedora/RISCV (applied by default on > top of 5.2-rc7 kernel for <2 months). The patch was also tested with 5.3-rc > on QEMU and SiFive Unleashed board. Oops, I see the mention of QEMU here. Where's the best place to find instructions on creating a qemu riscv image/environment? > There is one failing kernel selftest: global.user_notification_signal This test has been fragile (and is not arch-specific), so as long as everything else is passing, I would call this patch ready to go. :) Reviewed-by: Kees Cook -- Kees Cook