From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF548C352AA for ; Wed, 2 Oct 2019 17:34:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BC72021D81 for ; Wed, 2 Oct 2019 17:34:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="XfhIFnWg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728269AbfJBReD (ORCPT ); Wed, 2 Oct 2019 13:34:03 -0400 Received: from mail-qk1-f202.google.com ([209.85.222.202]:45761 "EHLO mail-qk1-f202.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727751AbfJBReD (ORCPT ); Wed, 2 Oct 2019 13:34:03 -0400 Received: by mail-qk1-f202.google.com with SMTP id s14so19165512qkg.12 for ; Wed, 02 Oct 2019 10:34:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=LCLLRHRqh5eDd/+AOwIrEOhvR2+XuRvYX6if88062Ec=; b=XfhIFnWgdn/7czF/MbMf9RFlAwx6xltTqS+edMHXHHwuOLs+nwCLXZrvFk6PjnE2j/ UkJNv6mSHILbrycrOEgfat+Jphl+qK39Nl4MaldlUiqPJ7w/YfuSIez8FVW2j6iNUtm1 VpPJViIiCDIhUoEBnXY1pKcCvyXE/YR47tncZpCVeMjPQ5GWQipX+3Kt2hl7QtU9qn07 YWXHiCo+/yT8mH8ZWAWAlScbhr7SdwRtBuajpdG4DAs/l8+KkJ3U4Zes3aHrvvF0gRWD X/xhmqBTM6O6Q09gqj34cl367cexQsL8jvQs29G5En3+/P1zpYeAwDnj/YI6gze7qdbA kxgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=LCLLRHRqh5eDd/+AOwIrEOhvR2+XuRvYX6if88062Ec=; b=Bwwd2DQc65r3w6GKyZNq43SosWirYDmvFnwpwLyR3wlJLDmNzy/pcSiZt2EoLGqr0x crHSVIL5vMaPHExiWgiZsh5xBMa/1OV96nH3WytvpT/c+XGTSIyOGNZCXiRynbBeyRik VVIag2iYDttQHv2333z6/IRyfuxoUnykbmMPOPR5NtylOylt4TxHq2oGoICN0G06hFZG h9o4D0jOE7w9XK5ND3OHvXsD2K4TWdlsGMVzjUkhaKR4sbxCH56pq4MLl9N1Ud+uuNYz kGMnKLMksb7H33aCB/IlJmZ61NbO1kn9h4gSR5oW+KUN10z3R7EEtIRwDQz50qDYjvqR AH4Q== X-Gm-Message-State: APjAAAXuPmo/Wmla+4vHY4bmRohiDhlLHkEW/k2qcKtXDYMCCgsIRx4X qK7GMhcq0PuHKceGTVCvNrw7y7U= X-Google-Smtp-Source: APXvYqwesAzQXb+pDDcFzHFZaa/1FLKUuQE5iCGv8xR9RwgCJq8EeN1ef/rTmL0AMcKF+f1k7Dbqc/M= X-Received: by 2002:a05:6214:452:: with SMTP id cc18mr4124598qvb.41.1570037640285; Wed, 02 Oct 2019 10:34:00 -0700 (PDT) Date: Wed, 2 Oct 2019 10:33:55 -0700 Message-Id: <20191002173357.253643-1-sdf@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.23.0.444.g18eeb5a265-goog Subject: [PATCH bpf-next 0/2] bpf/flow_dissector: add mode to enforce global BPF flow dissector From: Stanislav Fomichev To: netdev@vger.kernel.org, bpf@vger.kernel.org Cc: davem@davemloft.net, ast@kernel.org, daniel@iogearbox.net, Stanislav Fomichev , Petar Penkov Content-Type: text/plain; charset="UTF-8" Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org While having a per-net-ns flow dissector programs is convenient for testing, security-wise it's better to have only one vetted global flow dissector implementation. Let's have a convention that when BPF flow dissector is installed in the root namespace, child namespaces can't override it. Note, that it's totally possible to attach flow_dissector programs to several namespaces and then switch to a global one. In this case, only the root one will trigger; users are still able to detach flow_dissector programs from non-root namespaces. Alternative solution might be something like a sysctl to enable the global mode. Cc: Petar Penkov Stanislav Fomichev (2): bpf/flow_dissector: add mode to enforce global BPF flow dissector selftests/bpf: add test for BPF flow dissector in the root namespace Documentation/bpf/prog_flow_dissector.rst | 3 ++ net/core/flow_dissector.c | 11 ++++- .../selftests/bpf/test_flow_dissector.sh | 48 ++++++++++++++++--- 3 files changed, 55 insertions(+), 7 deletions(-) -- 2.23.0.444.g18eeb5a265-goog