From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A238ECE58E for ; Tue, 8 Oct 2019 15:26:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 52899206C0 for ; Tue, 8 Oct 2019 15:26:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=fomichev-me.20150623.gappssmtp.com header.i=@fomichev-me.20150623.gappssmtp.com header.b="dqkf+Zpr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727228AbfJHP0q (ORCPT ); Tue, 8 Oct 2019 11:26:46 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:36582 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725966AbfJHP0p (ORCPT ); Tue, 8 Oct 2019 11:26:45 -0400 Received: by mail-pg1-f194.google.com with SMTP id 23so10439729pgk.3 for ; Tue, 08 Oct 2019 08:26:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fomichev-me.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ukGqWj5a1FeSJU0pzE0V4T+cj7qN53c/aquLzSv6y94=; b=dqkf+ZprkXFVcxFXkXIDOQAPKllrX1M6J7JTd3uE7yvdnmhEulq3lkYjnd+1DflPNk 4mVwid7A90bJqpgVt2s3SZc4z9TIryZC1XqcvFFICMMu7YnA3gIbDYBUl2uwsl1dv+Z4 t2mX8x3DiVccFyPARNRvAQJ8CgIWdvAVEUff1jRZHo3l4b6zZ6WZMd3ak45tQpdSA9/l 7/XMnsW+WhTKdTlH91axXYBBq948GlGlTRAvQxgeF/iWnqRd4mVvFVzS81NVa3qqQXbT cOh2VsLcnhlcGhrvBnwM9j/P2CFOcpbnUBWF3I8PR8rJw3Ca5GkuFHwigJVGXtWn5Rjl Y2vA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ukGqWj5a1FeSJU0pzE0V4T+cj7qN53c/aquLzSv6y94=; b=bBYtmIJ8kjzTtyeCKr0xtYhLx1M5huhpu7/5bhph/vxfYEdG/+0b1K5fMa6QpQtRSz u4ngvhl9Ww3J+6l0nXVU2xUTPjNyPVUXQUIibnX4H88G3zLvdExUV2Ff+h7YSzOaBle0 OS+mvsNaJmWVHYxAdUjEjhAgm6IuUDBF+0OBGvWCZFFGpmiX1Zs/GhxRmxl32Uj6RqzE jNthnXHevyq2ztEdr5jrfg2kaHQGJumjoIIyzVPQxvmf5nsIWI4PjQ6yf4loaA+P9Ke4 c0athKZjCJkhUcWBg9XtzhGB992oZ4uL/SEFYW2mRanerB6DcuqKHZU7QAL/wslikO1b 6SHw== X-Gm-Message-State: APjAAAWa+tDIU2Vdh3cYv1ce8inNK5KADEybEiQAm6U4fCCAB5IGPkht 5+AFh2453RzZEi1NvcE2TxcsYg== X-Google-Smtp-Source: APXvYqxBO2iZovZc62Tudrbl7YZA7NOxm4NfIRO8QC1VBoxV3wwBvdR/5hAlEFkUmwouqWE5jcxolw== X-Received: by 2002:a63:6c89:: with SMTP id h131mr36854264pgc.380.1570548403251; Tue, 08 Oct 2019 08:26:43 -0700 (PDT) Received: from localhost ([2601:646:8f00:18d9:d0fa:7a4b:764f:de48]) by smtp.gmail.com with ESMTPSA id j25sm18518231pfi.113.2019.10.08.08.26.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Oct 2019 08:26:42 -0700 (PDT) Date: Tue, 8 Oct 2019 08:26:41 -0700 From: Stanislav Fomichev To: Andrii Nakryiko Cc: Andrii Nakryiko , bpf , Networking , Alexei Starovoitov , Daniel Borkmann , Stanislav Fomichev , Kernel Team Subject: Re: [PATCH bpf-next] bpftool: fix bpftool build by switching to bpf_object__open_file() Message-ID: <20191008152641.GD2096@mini-arch> References: <20191007212237.1704211-1-andriin@fb.com> <20191007214650.GC2096@mini-arch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On 10/07, Andrii Nakryiko wrote: > -- Andrii > > On Mon, Oct 7, 2019 at 2:50 PM Andrii Nakryiko > wrote: > > > > On Mon, Oct 7, 2019 at 2:46 PM Stanislav Fomichev wrote: > > > > > > On 10/07, Andrii Nakryiko wrote: > > > > As part of libbpf in 5e61f2707029 ("libbpf: stop enforcing kern_version, > > > > populate it for users") non-LIBBPF_API __bpf_object__open_xattr() API > > > > was removed from libbpf.h header. This broke bpftool, which relied on > > > > that function. This patch fixes the build by switching to newly added > > > > bpf_object__open_file() which provides the same capabilities, but is > > > > official and future-proof API. > > > > > > > > Fixes: 5e61f2707029 ("libbpf: stop enforcing kern_version, populate it for users") > > > > Reported-by: Stanislav Fomichev > > > > Signed-off-by: Andrii Nakryiko > > > > --- > > > > tools/bpf/bpftool/main.c | 4 ++-- > > > > tools/bpf/bpftool/main.h | 2 +- > > > > tools/bpf/bpftool/prog.c | 22 ++++++++++++---------- > > > > 3 files changed, 15 insertions(+), 13 deletions(-) > > > > > > [...] > > > > > --- a/tools/bpf/bpftool/prog.c > > > > +++ b/tools/bpf/bpftool/prog.c > > > > @@ -1092,9 +1092,7 @@ static int do_run(int argc, char **argv) > > > > static int load_with_options(int argc, char **argv, bool first_prog_only) > > > > { > > > > struct bpf_object_load_attr load_attr = { 0 }; > > > > - struct bpf_object_open_attr open_attr = { > > > > - .prog_type = BPF_PROG_TYPE_UNSPEC, > > > > - }; > > > > + enum bpf_prog_type prog_type = BPF_PROG_TYPE_UNSPEC; > > > > enum bpf_attach_type expected_attach_type; > > > > struct map_replace *map_replace = NULL; > > [...] > > > > > > > > > bpf_object__for_each_program(pos, obj) { > > > > - enum bpf_prog_type prog_type = open_attr.prog_type; > > > > + enum bpf_prog_type prog_type = prog_type; > > > Are you sure it works that way? > > > > Oh, I did this pretty mechanically, didn't notice I'm shadowing. In > > either case I'd like to avoid shadowing, so I'll rename one of them, > > good catch! > > > > > > > > $ cat tmp.c > > > #include > > > > > > int main() > > > { > > > int x = 1; > > > printf("outer x=%d\n", x); > > > > > > { > > > int x = x; > > It's amazing `int x = x;` is compiled successfully when there is no x > in outer scope. And it's also amazing that it's doing the wrong thing > when there is a shadowed variable in outer scope. I can't imagine the > case where this will be a meaningful behavior... Enjoy your daily dose of undefined behavior :-D > > > printf("inner x=%d\n", x); > > > } > > > > > > return 0; > > > } > > > > > > $ gcc tmp.c && ./a.out > > > outer x=1 > > > inner x=0 > > > > > > Other than that: > > > Reviewed-by: Stanislav Fomichev > > > > > > > > > > > - if (open_attr.prog_type == BPF_PROG_TYPE_UNSPEC) { > > > > + if (prog_type == BPF_PROG_TYPE_UNSPEC) { > > > > const char *sec_name = bpf_program__title(pos, false); > > > > > > > > err = libbpf_prog_type_by_name(sec_name, &prog_type, > > > > -- > > > > 2.17.1 > > > >