From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 535D2CA9EA1 for ; Fri, 18 Oct 2019 07:05:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2E2F821D80 for ; Fri, 18 Oct 2019 07:05:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727315AbfJRHFB (ORCPT ); Fri, 18 Oct 2019 03:05:01 -0400 Received: from mx2.suse.de ([195.135.220.15]:38934 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727011AbfJRHFB (ORCPT ); Fri, 18 Oct 2019 03:05:01 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 51E31AC18; Fri, 18 Oct 2019 07:04:59 +0000 (UTC) Date: Fri, 18 Oct 2019 09:04:57 +0200 From: Petr Mladek To: Alexei Starovoitov Cc: Kefeng Wang , linux-kernel@vger.kernel.org, Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , bpf@vger.kernel.org, Andrii Nakryiko , Sergey Senozhatsky Subject: Re: [PATCH v2 31/33] tools lib bpf: Renaming pr_warning to pr_warn Message-ID: <20191018070457.ge3wcpdle6pwtsxd@pathway.suse.cz> References: <20191018031710.41052-1-wangkefeng.wang@huawei.com> <20191018031850.48498-1-wangkefeng.wang@huawei.com> <20191018031850.48498-31-wangkefeng.wang@huawei.com> <20191018042416.r4fffxzbxb3u4csg@ast-mbp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191018042416.r4fffxzbxb3u4csg@ast-mbp> User-Agent: NeoMutt/20170912 (1.9.0) Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Thu 2019-10-17 21:24:19, Alexei Starovoitov wrote: > On Fri, Oct 18, 2019 at 11:18:48AM +0800, Kefeng Wang wrote: > > For kernel logging macro, pr_warning is completely removed and > > replaced by pr_warn, using pr_warn in tools lib bpf for symmetry > > to kernel logging macro, then we could drop pr_warning in the > > whole linux code. > > > > Cc: Alexei Starovoitov > > Cc: Daniel Borkmann > > Cc: Martin KaFai Lau > > Cc: Song Liu > > Cc: Yonghong Song > > Cc: bpf@vger.kernel.org > > Acked-by: Andrii Nakryiko > > Reviewed-by: Sergey Senozhatsky > > Signed-off-by: Kefeng Wang > > --- > > tools/lib/bpf/btf.c | 56 +-- > > tools/lib/bpf/btf_dump.c | 18 +- > > tools/lib/bpf/libbpf.c | 679 ++++++++++++++++---------------- > > tools/lib/bpf/libbpf_internal.h | 8 +- > > tools/lib/bpf/xsk.c | 4 +- > > 5 files changed, 379 insertions(+), 386 deletions(-) > > Nack. > I prefer this type of renaming to go via bpf tree. > It's not a kernel patch. It's touching user space library > which is under heavy development. > Doing any other way will cause a ton of conflicts. Fair enough. I'll ignore this patch. Could I assume that it will be taken via bpf tree, please? I'll also postpone the patch that removes pr_warning() to avoid synchronization problems. I'll push it later when changes in bpf[*] subsystem are merged. [*] I am going to check conflicts against 5.4-rc1. I'll probably ask more subsystems to take their changes to avoid conflicts and make it smooth. Best Regards, Petr