From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: "Toke Høiland-Jørgensen" <toke@redhat.com>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Alexei Starovoitov" <ast@fb.com>, bpf <bpf@vger.kernel.org>,
"Network Development" <netdev@vger.kernel.org>,
"Tetsuo Handa" <penguin-kernel@i-love.sakura.ne.jp>,
"Yonghong Song" <yhs@fb.com>
Subject: Re: [PATCH bpf] xdp: Prevent overflow in devmap_hash cost calculation for 32-bit builds
Date: Fri, 18 Oct 2019 16:31:56 -0700 [thread overview]
Message-ID: <20191018163156.278f4ca5@cakuba.netronome.com> (raw)
In-Reply-To: <CAADnVQKDaMAVT6UxGy8w+CPUmzvgVWAjXmHexiz09yZJ8CbAeQ@mail.gmail.com>
On Fri, 18 Oct 2019 16:25:24 -0700, Alexei Starovoitov wrote:
> I'm not sure that cleanup Jakub is proposing is possible or better.
> Not everything is array_size here and in other places
> where cost is computed. u64 is imo much cleaner.
Right, adding multiple components with size_t is going to be
unnecessarily tricky.
next prev parent reply other threads:[~2019-10-18 23:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 10:57 [PATCH bpf] xdp: Prevent overflow in devmap_hash cost calculation for 32-bit builds Toke Høiland-Jørgensen
2019-10-17 18:52 ` Jakub Kicinski
2019-10-18 9:15 ` Toke Høiland-Jørgensen
2019-10-18 17:19 ` Jakub Kicinski
2019-10-18 16:44 ` Yonghong Song
2019-10-18 23:25 ` Alexei Starovoitov
2019-10-18 23:31 ` Jakub Kicinski [this message]
2019-10-19 0:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191018163156.278f4ca5@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=alexei.starovoitov@gmail.com \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=toke@redhat.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox