From: Wang YanQing <udknight@gmail.com>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
Alexei Starovoitov <ast@kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>,
bpf@vger.kernel.org
Subject: Re: Fw: [Bug 205469] New: x86_32: bpf: multiple test_bpf failures using eBPF JIT
Date: Sun, 10 Nov 2019 02:36:03 +0800 [thread overview]
Message-ID: <20191109183602.GA1033@udknight> (raw)
In-Reply-To: <08b98fbd-f295-3a94-8b3e-70790179290c@iogearbox.net>
On Sat, Nov 09, 2019 at 12:37:49AM +0100, Daniel Borkmann wrote:
> [ Cc Wang (x86_32 BPF JIT maintainer) ]
>
> On 11/8/19 4:57 PM, Stephen Hemminger wrote:
> >
> > Begin forwarded message:
> >
> > Date: Fri, 08 Nov 2019 07:35:59 +0000
> > From: bugzilla-daemon@bugzilla.kernel.org
> > To: stephen@networkplumber.org
> > Subject: [Bug 205469] New: x86_32: bpf: multiple test_bpf failures using eBPF JIT
> >
> >
> > https://bugzilla.kernel.org/show_bug.cgi?id=205469
> >
> > Bug ID: 205469
> > Summary: x86_32: bpf: multiple test_bpf failures using eBPF JIT
> > Product: Networking
> > Version: 2.5
> > Kernel Version: 4.19.81 LTS
> > Hardware: i386
> > OS: Linux
> > Tree: Mainline
> > Status: NEW
> > Severity: normal
> > Priority: P1
> > Component: Other
> > Assignee: stephen@networkplumber.org
> > Reporter: itugrok@yahoo.com
> > CC: itugrok@yahoo.com
> > Regression: No
> >
> > Created attachment 285829
> > --> https://bugzilla.kernel.org/attachment.cgi?id=285829&action=edit
> > test_bpf failures: kernel 4.19.81/x86_32 (OpenWrt)
> >
> > Summary:
> > ========
> >
> > Running the 4.19.81 LTS kernel on QEMU/x86_32, the standard test_bpf.ko
> > testsuite generates multiple errors with the eBPF JIT enabled:
> >
> > ...
> > test_bpf: #32 JSET jited:1 40 ret 0 != 20 46 FAIL
> > test_bpf: #321 LD_IND word positive offset jited:1 ret 0 != -291897430 FAIL
> > test_bpf: #322 LD_IND word negative offset jited:1 ret 0 != -1437222042 FAIL
> > test_bpf: #323 LD_IND word unaligned (addr & 3 == 2) jited:1 ret 0 !=
> > -1150890889 FAIL
> > test_bpf: #326 LD_IND word positive offset, all ff jited:1 ret 0 != -1 FAIL
> > ...
> > test_bpf: Summary: 373 PASSED, 5 FAILED, [344/366 JIT'ed]
> >
> > However, with eBPF JIT disabled (net.core.bpf_jit_enable=0) all tests pass.
> >
> >
> > Steps to Reproduce:
> > ===================
> >
> > # sysctl net.core.bpf_jit_enable=1
> > # modprobe test_bpf
> > <Kernel log with failures and test summary>
> >
> >
> > Affected Systems Tested:
> > ========================
> >
> > OpenWrt master on QEMU/pc-q35(x86_32) [LTS kernel 4.19.81]
> >
> >
> > Kernel Logs:
> > ============
> >
> > Boot log with test results is attached.
> >
Hi Daniel Borkmann!
I have tested and verified that the report bug has been fixed by commit
711aef1bbf88 ("bpf, x32: Fix bug for BPF_JMP | {BPF_JSGT, BPF_JSLE, BPF_JSLT, BPF_JSGE}")
But that fix hasn't been backport to stable trees, so maybe we should do it:)
next prev parent reply other threads:[~2019-11-09 19:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 15:57 Fw: [Bug 205469] New: x86_32: bpf: multiple test_bpf failures using eBPF JIT Stephen Hemminger
2019-11-08 23:37 ` Daniel Borkmann
2019-11-09 18:36 ` Wang YanQing [this message]
2019-11-11 12:56 ` Daniel Borkmann
2019-11-21 20:37 ` Greg KH
2019-11-21 20:42 ` Daniel Borkmann
2019-11-21 20:47 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191109183602.GA1033@udknight \
--to=udknight@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kafai@fb.com \
--cc=songliubraving@fb.com \
--cc=stephen@networkplumber.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox