From: Andrii Nakryiko <andriin@fb.com>
To: <bpf@vger.kernel.org>, <netdev@vger.kernel.org>, <ast@fb.com>,
<daniel@iogearbox.net>
Cc: <andrii.nakryiko@gmail.com>, <kernel-team@fb.com>,
Andrii Nakryiko <andriin@fb.com>
Subject: [PATCH v3 bpf-next 0/3] Skeleton improvements and documentation
Date: Tue, 17 Dec 2019 21:25:49 -0800 [thread overview]
Message-ID: <20191218052552.2915188-1-andriin@fb.com> (raw)
Simplify skeleton usage by embedding source BPF object file inside skeleton
itself. This allows to keep skeleton and object file in sync at all times with
no chance of confusion.
Also, add bpftool-gen.rst manpage, explaining concepts and ideas behind
skeleton. In examples section it also includes a complete small BPF
application utilizing skeleton, as a demonstration of API.
Patch #2 also removes BPF_EMBED_OBJ, as there is currently no use of it.
v2->v3:
- (void) in no-args function (Alexei);
- bpftool-gen.rst code block formatting fix (Alexei);
- simplified xxx__create_skeleton to fill in obj and return error code;
v1->v2:
- remove whitespace from empty lines in code blocks (Yonghong).
Andrii Nakryiko (3):
bpftool, selftests/bpf: embed object file inside skeleton
libbpf: remove BPF_EMBED_OBJ macro from libbpf.h
bpftool: add gen subcommand manpage
.../bpf/bpftool/Documentation/bpftool-gen.rst | 304 ++++++++++++++++++
tools/bpf/bpftool/Documentation/bpftool.rst | 3 +-
tools/bpf/bpftool/gen.c | 232 ++++++++-----
tools/lib/bpf/libbpf.h | 35 --
.../selftests/bpf/prog_tests/attach_probe.c | 4 +-
.../selftests/bpf/prog_tests/core_extern.c | 4 +-
.../selftests/bpf/prog_tests/fentry_fexit.c | 10 +-
.../selftests/bpf/prog_tests/fentry_test.c | 7 +-
tools/testing/selftests/bpf/prog_tests/mmap.c | 4 +-
.../selftests/bpf/prog_tests/skeleton.c | 4 +-
.../bpf/prog_tests/stacktrace_build_id.c | 4 +-
.../bpf/prog_tests/stacktrace_build_id_nmi.c | 4 +-
12 files changed, 460 insertions(+), 155 deletions(-)
create mode 100644 tools/bpf/bpftool/Documentation/bpftool-gen.rst
--
2.17.1
next reply other threads:[~2019-12-18 5:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 5:25 Andrii Nakryiko [this message]
2019-12-18 5:25 ` [PATCH v3 bpf-next 1/3] bpftool, selftests/bpf: embed object file inside skeleton Andrii Nakryiko
2019-12-18 5:25 ` [PATCH v3 bpf-next 2/3] libbpf: remove BPF_EMBED_OBJ macro from libbpf.h Andrii Nakryiko
2019-12-18 5:25 ` [PATCH v3 bpf-next 3/3] bpftool: add gen subcommand manpage Andrii Nakryiko
2019-12-18 6:23 ` [PATCH v3 bpf-next 0/3] Skeleton improvements and documentation Alexei Starovoitov
2019-12-18 18:31 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191218052552.2915188-1-andriin@fb.com \
--to=andriin@fb.com \
--cc=andrii.nakryiko@gmail.com \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox