From: David Miller <davem@davemloft.net>
To: lorenzo.bianconi@redhat.com
Cc: brouer@redhat.com, lorenzo@kernel.org, netdev@vger.kernel.org,
ilias.apalodimas@linaro.org, dsahern@kernel.org,
bpf@vger.kernel.org
Subject: Re: [PATCH net-next 4/5] net: mvneta: introduce xdp counters to ethtool
Date: Mon, 17 Feb 2020 14:18:50 -0800 (PST) [thread overview]
Message-ID: <20200217.141850.2134390863127670308.davem@davemloft.net> (raw)
In-Reply-To: <20200217102550.GB3080@localhost.localdomain>
From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Date: Mon, 17 Feb 2020 11:25:50 +0100
> yes, I think it is definitely better. So to follow up:
> - rename current "xdp_tx" counter in "xdp_xmit" and increment it for
> XDP_TX verdict and for ndo_xdp_xmit
> - introduce a new "xdp_tx" counter only for XDP_TX verdict.
>
> If we agree I can post a follow-up patch.
What names do other drivers use? Consistency is important. I noticed
while reviewing these patches that mellanox drivers export similar
statistics in the exact same way.
next prev parent reply other threads:[~2020-02-17 22:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1581886691.git.lorenzo@kernel.org>
[not found] ` <882d9f03a8542cceec7c7b8e6d083419d84eaf7a.1581886691.git.lorenzo@kernel.org>
2020-02-17 10:17 ` [PATCH net-next 4/5] net: mvneta: introduce xdp counters to ethtool Jesper Dangaard Brouer
2020-02-17 10:25 ` Lorenzo Bianconi
2020-02-17 10:32 ` Jesper Dangaard Brouer
2020-02-17 13:05 ` Andrew Lunn
2020-02-17 14:51 ` Jesper Dangaard Brouer
2020-02-17 18:17 ` David Ahern
2020-02-17 22:18 ` David Miller [this message]
2020-02-17 22:38 ` Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200217.141850.2134390863127670308.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=dsahern@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox