RE: [PATCH bpf-next v3 05/12] bpf: sockmap: move generic sockmap hooks from BPF TCP

John Fastabend
2020-03-06T15:28:26Z

Lorenz Bauer wrote:
> The init, close and unhash handlers from TCP sockmap are generic,
> and can be reused by UDP sockmap. Move the helpers into the sockmap code
> base and expose them. This requires tcp_bpf_get_proto and tcp_bpf_clone to
> be conditional on BPF_STREAM_PARSER.
>
> The moved functions are unmodified, except that sk_psock_unlink is
> renamed to sock_map_unlink to better match its behaviour.
>
> Signed-off-by: Lorenz Bauer <lmb@cloudflare.com>
> ---
> include/linux/bpf.h | 4 +-
> include/linux/skmsg.h | 28 -----------
> include/net/tcp.h | 15 +++---
> net/core/sock_map.c | 106 ++++++++++++++++++++++++++++++++++++++++--
> net/ipv4/tcp_bpf.c | 84 ++-------------------------------
> 5 files changed, 118 insertions(+), 119 deletions(-)

Acked-by: John Fastabend <john.fastabend@gmail.com>