RE: [PATCH bpf-next v3 11/12] selftests: bpf: enable UDP sockmap reuseport tests

John Fastabend
2020-03-06T15:39:40Z

Lorenz Bauer wrote:
> Remove the guard that disables UDP tests now that sockmap
> has support for them.
>
> Signed-off-by: Lorenz Bauer <lmb@cloudflare.com>
> ---
> tools/testing/selftests/bpf/prog_tests/select_reuseport.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/tools/testing/selftests/bpf/prog_tests/select_reuseport.c b/tools/testing/selftests/bpf/prog_tests/select_reuseport.c
> index a1dd13b34d4b..821b4146b7b6 100644
> --- a/tools/testing/selftests/bpf/prog_tests/select_reuseport.c
> +++ b/tools/testing/selftests/bpf/prog_tests/select_reuseport.c
> @@ -805,12 +805,6 @@ static void test_config(int sotype, sa_family_t family, bool inany)
> char s[MAX_TEST_NAME];
> const struct test *t;
>
> - /* SOCKMAP/SOCKHASH don't support UDP yet */
> - if (sotype == SOCK_DGRAM &&
> - (inner_map_type == BPF_MAP_TYPE_SOCKMAP ||
> - inner_map_type == BPF_MAP_TYPE_SOCKHASH))
> - return;
> -
> for (t = tests; t < tests + ARRAY_SIZE(tests); t++) {
> if (t->need_sotype && t->need_sotype != sotype)
> continue; /* test not compatible with socket type */
> --
> 2.20.1
>

Acked-by: John Fastabend <john.fastabend@gmail.com>