Re: [PATCH RFC v1 09/15] xdp: clear grow memory in bpf_xdp_adjust_tail()

Jakub Kicinski
2020-03-17T20:38:49Z

On Tue, 17 Mar 2020 18:29:53 +0100 Jesper Dangaard Brouer wrote:
> To reviewers: Need some opinions if this is needed?
>
> (TODO: Squash patch)

I'd vote we don't clear, since we don't clear in adjust head.

We could also add some wrapper around memset() which could be compiled
out based on some CONFIG_ but that could be seen as just moving the
responsibility onto the user..

> diff --git a/net/core/filter.c b/net/core/filter.c
> index 0ceddee0c678..669f29992177 100644
> --- a/net/core/filter.c
> +++ b/net/core/filter.c
> @@ -3432,6 +3432,12 @@ BPF_CALL_2(bpf_xdp_adjust_tail, struct xdp_buff *, xdp, int, offset)
> if (unlikely(data_end < xdp->data + ETH_HLEN))
> return -EINVAL;
>
> + // XXX: To reviewers: How paranoid are we? Do we really need to
> + /* clear memory area on grow, as in-theory can contain uninit kmem */
> + if (offset > 0) {
> + memset(xdp->data_end, 0, offset);
> + }
> +
> xdp->data_end = data_end;
>
> return 0;
>
>