Re: [PATCH bpf-next v6 1/8] bpf: Introduce BPF_PROG_TYPE_LSM

Andrii Nakryiko
2020-03-26T01:52:02Z

On Wed, Mar 25, 2020 at 8:27 AM KP Singh <kpsingh@chromium.org> wrote:
>
> From: KP Singh <kpsingh@google.com>
>
> Introduce types and configs for bpf programs that can be attached to
> LSM hooks. The programs can be enabled by the config option
> CONFIG_BPF_LSM.
>
> Signed-off-by: KP Singh <kpsingh@google.com>
> Reviewed-by: Brendan Jackman <jackmanb@google.com>
> Reviewed-by: Florent Revest <revest@google.com>
> Reviewed-by: Thomas Garnier <thgarnie@google.com>
> Acked-by: Yonghong Song <yhs@fb.com>
> ---

Looks good to me, so please add by ack, but I think it would be easier
to review if this was combined with patch #4, which adds verifier
support and kernel/bpf/syscall.c support. On its own this patch just
adds random unused stuff.

Acked-by: Andrii Nakryiko <andriin@fb.com>

> MAINTAINERS | 1 +
> include/linux/bpf.h | 3 +++
> include/linux/bpf_types.h | 4 ++++
> include/uapi/linux/bpf.h | 2 ++
> init/Kconfig | 12 ++++++++++++
> kernel/bpf/Makefile | 1 +
> kernel/bpf/bpf_lsm.c | 17 +++++++++++++++++
> kernel/trace/bpf_trace.c | 12 ++++++------
> tools/include/uapi/linux/bpf.h | 2 ++
> tools/lib/bpf/libbpf_probes.c | 1 +
> 10 files changed, 49 insertions(+), 6 deletions(-)
> create mode 100644 kernel/bpf/bpf_lsm.c
> …