public inbox for bpf@vger.kernel.org
 help / color / mirror / Atom feed
From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Veronika Kabatova <vkabatov@redhat.com>
Cc: bpf@vger.kernel.org, andriin@fb.com, brouer@redhat.com
Subject: Re: [PATCH] selftests/bpf: Copy runqslower to OUTPUT directory
Date: Mon, 27 Apr 2020 17:48:24 +0200	[thread overview]
Message-ID: <20200427174824.413b2be9@carbon> (raw)
In-Reply-To: <20200427160240.5e66a954@carbon>

On Mon, 27 Apr 2020 16:02:40 +0200
Jesper Dangaard Brouer <brouer@redhat.com> wrote:

> On Mon, 27 Apr 2020 15:29:40 +0200
> Veronika Kabatova <vkabatov@redhat.com> wrote:
> 
> > $(OUTPUT)/runqslower makefile target doesn't actually create runqslower
> > binary in the $(OUTPUT) directory. As lib.mk expects all
> > TEST_GEN_PROGS_EXTENDED (which runqslower is a part of) to be present in
> > the OUTPUT directory, this results in an error when running e.g. `make
> > install`:
> > 
> > rsync: link_stat "tools/testing/selftests/bpf/runqslower" failed: No
> >        such file or directory (2)
> > 
> > Copy the binary into the OUTPUT directory after building it to fix the
> > error.
> > 
> > Signed-off-by: Veronika Kabatova <vkabatov@redhat.com>
> > ---  
> 
> Looks good to me
> 
> Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>

Let us add a Fixes tag (patchwork should pick this up).

Fixes: 3a0d3092a4ed ("selftests/bpf: Build runqslower from selftests")

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer


  reply	other threads:[~2020-04-27 15:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200427132940.2857289-1-vkabatov@redhat.com>
2020-04-27 14:02 ` [PATCH] selftests/bpf: Copy runqslower to OUTPUT directory Jesper Dangaard Brouer
2020-04-27 15:48   ` Jesper Dangaard Brouer [this message]
2020-04-27 20:18   ` Andrii Nakryiko
2020-04-28 14:40     ` Veronika Kabatova

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200427174824.413b2be9@carbon \
    --to=brouer@redhat.com \
    --cc=andriin@fb.com \
    --cc=bpf@vger.kernel.org \
    --cc=vkabatov@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox