From: Jiri Benc <jbenc@redhat.com>
To: Yauheni Kaliuta <yauheni.kaliuta@redhat.com>
Cc: bpf@vger.kernel.org, Jiri Olsa <jolsa@redhat.com>,
Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH v2 2/3] selftests: fix condition in run_tests
Date: Fri, 15 May 2020 14:40:25 +0200 [thread overview]
Message-ID: <20200515144025.20495d63@redhat.com> (raw)
In-Reply-To: <20200515120026.113278-3-yauheni.kaliuta@redhat.com>
On Fri, 15 May 2020 15:00:25 +0300, Yauheni Kaliuta wrote:
> The check if there are any files to install in case of no files
> compares "X " with "X" so never false.
>
> Remove extra spaces. It may make sense to use make's $(if) function
> here.
>
> Signed-off-by: Yauheni Kaliuta <yauheni.kaliuta@redhat.com>
Acked-by: Jiri Benc <jbenc@redhat.com>
next prev parent reply other threads:[~2020-05-15 12:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 12:00 [PATCH v2 0/3] selftests: lib.mk improvements Yauheni Kaliuta
2020-05-15 12:00 ` [PATCH v2 1/3] selftests: do not use .ONESHELL Yauheni Kaliuta
2020-05-15 12:40 ` Jiri Benc
2020-05-19 7:44 ` Yauheni Kaliuta
2020-05-15 12:00 ` [PATCH v2 2/3] selftests: fix condition in run_tests Yauheni Kaliuta
2020-05-15 12:40 ` Jiri Benc [this message]
2020-05-15 12:00 ` [PATCH v2 3/3] selftests: simplify run_tests Yauheni Kaliuta
2020-05-19 13:59 ` [PATCH v2 0/3] selftests: lib.mk improvements shuah
2020-05-19 14:49 ` Yauheni Kaliuta
2020-05-22 15:09 ` shuah
2020-05-22 15:38 ` Yauheni Kaliuta
2020-05-26 17:18 ` shuah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200515144025.20495d63@redhat.com \
--to=jbenc@redhat.com \
--cc=bpf@vger.kernel.org \
--cc=jolsa@redhat.com \
--cc=shuah@kernel.org \
--cc=yauheni.kaliuta@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox